Skip to content

Commit 280de93

Browse files
author
Kai Hudalla
committed
[#1518] Remove dependency to legacy Spring Boot support library.
The legacy library was required when using Micrometer with Spring Boot 1.5.x. Since the update to Spring Boot 2.1 we do not need it anymore. Fixes #1518 Signed-off-by: Kai Hudalla <[email protected]>
1 parent 663cd94 commit 280de93

File tree

12 files changed

+26
-25
lines changed
  • adapters
    • amqp-vertx/src/main/java/org/eclipse/hono/adapter/amqp/impl
    • coap-vertx/src/main/java/org/eclipse/hono/adapter/coap/impl
    • http-vertx/src/main/java/org/eclipse/hono/adapter/http/impl
    • kura/src/main/java/org/eclipse/hono/adapter/kura/impl
    • lora-vertx/src/main/java/org/eclipse/hono/adapter/lora/impl
    • mqtt-vertx/src/main/java/org/eclipse/hono/adapter/mqtt/impl
    • sigfox-vertx/src/main/java/org/eclipse/hono/adapter/sigfox/impl
  • bom
  • service-base
  • services

12 files changed

+26
-25
lines changed

adapters/amqp-vertx/src/main/java/org/eclipse/hono/adapter/amqp/impl/Config.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121
import org.eclipse.hono.service.monitoring.LoggingConnectionEventProducer;
2222
import org.eclipse.hono.util.Constants;
2323
import org.springframework.beans.factory.config.ObjectFactoryCreatingFactoryBean;
24+
import org.springframework.boot.actuate.autoconfigure.metrics.MeterRegistryCustomizer;
2425
import org.springframework.boot.context.properties.ConfigurationProperties;
2526
import org.springframework.context.annotation.Bean;
2627
import org.springframework.context.annotation.Configuration;
2728
import org.springframework.context.annotation.Scope;
2829

2930
import io.micrometer.core.instrument.MeterRegistry;
30-
import io.micrometer.spring.autoconfigure.MeterRegistryCustomizer;
3131

3232
/**
3333
* Spring Boot configuration for the AMQP protocol adapter.

adapters/coap-vertx/src/main/java/org/eclipse/hono/adapter/coap/impl/Config.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@
2020
import org.eclipse.hono.service.metric.MetricsTags;
2121
import org.eclipse.hono.util.Constants;
2222
import org.springframework.beans.factory.config.ObjectFactoryCreatingFactoryBean;
23+
import org.springframework.boot.actuate.autoconfigure.metrics.MeterRegistryCustomizer;
2324
import org.springframework.boot.context.properties.ConfigurationProperties;
2425
import org.springframework.context.annotation.Bean;
2526
import org.springframework.context.annotation.Configuration;
2627
import org.springframework.context.annotation.Scope;
2728

2829
import io.micrometer.core.instrument.MeterRegistry;
29-
import io.micrometer.spring.autoconfigure.MeterRegistryCustomizer;
3030

3131
/**
3232
* Spring Boot configuration for the COAP adapter.

adapters/http-vertx/src/main/java/org/eclipse/hono/adapter/http/impl/Config.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@
2020
import org.eclipse.hono.service.metric.MetricsTags;
2121
import org.eclipse.hono.util.Constants;
2222
import org.springframework.beans.factory.config.ObjectFactoryCreatingFactoryBean;
23+
import org.springframework.boot.actuate.autoconfigure.metrics.MeterRegistryCustomizer;
2324
import org.springframework.boot.context.properties.ConfigurationProperties;
2425
import org.springframework.context.annotation.Bean;
2526
import org.springframework.context.annotation.Configuration;
2627
import org.springframework.context.annotation.Scope;
2728

2829
import io.micrometer.core.instrument.MeterRegistry;
29-
import io.micrometer.spring.autoconfigure.MeterRegistryCustomizer;
3030

3131
/**
3232
* Spring Boot configuration for the HTTP adapter.

adapters/kura/src/main/java/org/eclipse/hono/adapter/kura/impl/Config.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121
import org.eclipse.hono.service.metric.MetricsTags;
2222
import org.eclipse.hono.util.Constants;
2323
import org.springframework.beans.factory.config.ObjectFactoryCreatingFactoryBean;
24+
import org.springframework.boot.actuate.autoconfigure.metrics.MeterRegistryCustomizer;
2425
import org.springframework.boot.context.properties.ConfigurationProperties;
2526
import org.springframework.context.annotation.Bean;
2627
import org.springframework.context.annotation.Configuration;
2728
import org.springframework.context.annotation.Scope;
2829

2930
import io.micrometer.core.instrument.MeterRegistry;
30-
import io.micrometer.spring.autoconfigure.MeterRegistryCustomizer;
3131

3232
/**
3333
* Spring Boot configuration for the Eclipse Kura protocol adapter.

adapters/lora-vertx/src/main/java/org/eclipse/hono/adapter/lora/impl/Config.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import org.eclipse.hono.service.metric.MetricsTags;
2424
import org.eclipse.hono.util.Constants;
2525
import org.springframework.beans.factory.config.ObjectFactoryCreatingFactoryBean;
26+
import org.springframework.boot.actuate.autoconfigure.metrics.MeterRegistryCustomizer;
2627
import org.springframework.boot.context.properties.ConfigurationProperties;
2728
import org.springframework.cache.CacheManager;
2829
import org.springframework.cache.annotation.EnableCaching;
@@ -32,7 +33,6 @@
3233
import org.springframework.context.annotation.Scope;
3334

3435
import io.micrometer.core.instrument.MeterRegistry;
35-
import io.micrometer.spring.autoconfigure.MeterRegistryCustomizer;
3636

3737
/**
3838
* Spring Boot configuration for the LoRa adapter.

adapters/mqtt-vertx/src/main/java/org/eclipse/hono/adapter/mqtt/impl/Config.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2016, 2018 Contributors to the Eclipse Foundation
2+
* Copyright (c) 2016, 2019 Contributors to the Eclipse Foundation
33
*
44
* See the NOTICE file(s) distributed with this work for additional
55
* information regarding copyright ownership.
@@ -23,14 +23,14 @@
2323
import org.eclipse.hono.service.monitoring.LoggingConnectionEventProducer;
2424
import org.eclipse.hono.util.Constants;
2525
import org.springframework.beans.factory.config.ObjectFactoryCreatingFactoryBean;
26+
import org.springframework.boot.actuate.autoconfigure.metrics.MeterRegistryCustomizer;
2627
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
2728
import org.springframework.boot.context.properties.ConfigurationProperties;
2829
import org.springframework.context.annotation.Bean;
2930
import org.springframework.context.annotation.Configuration;
3031
import org.springframework.context.annotation.Scope;
3132

3233
import io.micrometer.core.instrument.MeterRegistry;
33-
import io.micrometer.spring.autoconfigure.MeterRegistryCustomizer;
3434

3535
/**
3636
* Spring Boot configuration for the MQTT protocol adapter.

adapters/sigfox-vertx/src/main/java/org/eclipse/hono/adapter/sigfox/impl/Config.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121
import org.eclipse.hono.service.metric.MetricsTags;
2222
import org.eclipse.hono.util.Constants;
2323
import org.springframework.beans.factory.config.ObjectFactoryCreatingFactoryBean;
24+
import org.springframework.boot.actuate.autoconfigure.metrics.MeterRegistryCustomizer;
2425
import org.springframework.boot.context.properties.ConfigurationProperties;
2526
import org.springframework.context.annotation.Bean;
2627
import org.springframework.context.annotation.Configuration;
2728
import org.springframework.context.annotation.Scope;
2829

2930
import io.micrometer.core.instrument.MeterRegistry;
30-
import io.micrometer.spring.autoconfigure.MeterRegistryCustomizer;
3131

3232
/**
3333
* Spring Boot configuration for the Sigfox adapter.

bom/pom.xml

+11-5
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,11 @@
112112
<artifactId>spring-boot-autoconfigure</artifactId>
113113
<version>${spring-boot.version}</version>
114114
</dependency>
115+
<dependency>
116+
<groupId>org.springframework.boot</groupId>
117+
<artifactId>spring-boot-actuator-autoconfigure</artifactId>
118+
<version>${spring-boot.version}</version>
119+
</dependency>
115120
<dependency>
116121
<groupId>org.springframework.boot</groupId>
117122
<artifactId>spring-boot-starter-logging</artifactId>
@@ -129,11 +134,6 @@
129134
</exclusion>
130135
</exclusions>
131136
</dependency>
132-
<dependency>
133-
<groupId>io.micrometer</groupId>
134-
<artifactId>micrometer-spring-legacy</artifactId>
135-
<version>${micrometer.version}</version>
136-
</dependency>
137137
<dependency>
138138
<groupId>io.micrometer</groupId>
139139
<artifactId>micrometer-registry-graphite</artifactId>
@@ -546,6 +546,12 @@
546546
<artifactId>infinispan-client-hotrod</artifactId>
547547
<version>${infinispan.version}</version>
548548
</dependency>
549+
<dependency>
550+
<groupId>com.fasterxml.jackson.datatype</groupId>
551+
<artifactId>jackson-datatype-jsr310</artifactId>
552+
<version>${jackson.version}</version>
553+
<scope>runtime</scope>
554+
</dependency>
549555
</dependencies>
550556
</dependencyManagement>
551557
</project>

service-base/pom.xml

+4-5
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,6 @@
9898
<groupId>io.micrometer</groupId>
9999
<artifactId>micrometer-core</artifactId>
100100
</dependency>
101-
<dependency>
102-
<groupId>io.micrometer</groupId>
103-
<artifactId>micrometer-spring-legacy</artifactId>
104-
</dependency>
105101
<dependency>
106102
<groupId>io.vertx</groupId>
107103
<artifactId>vertx-micrometer-metrics</artifactId>
@@ -155,7 +151,6 @@
155151
<scope>compile</scope>
156152
<optional>true</optional>
157153
</dependency>
158-
159154
<dependency>
160155
<groupId>org.assertj</groupId>
161156
<artifactId>assertj-core</artifactId>
@@ -165,6 +160,10 @@
165160
<groupId>org.springframework.boot</groupId>
166161
<artifactId>spring-boot-autoconfigure</artifactId>
167162
</dependency>
163+
<dependency>
164+
<groupId>org.springframework.boot</groupId>
165+
<artifactId>spring-boot-actuator-autoconfigure</artifactId>
166+
</dependency>
168167
</dependencies>
169168

170169
<build>

services/auth/src/main/java/org/eclipse/hono/service/auth/impl/ApplicationConfig.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@
2626
import org.eclipse.hono.util.Constants;
2727
import org.springframework.beans.factory.annotation.Qualifier;
2828
import org.springframework.beans.factory.config.ObjectFactoryCreatingFactoryBean;
29+
import org.springframework.boot.actuate.autoconfigure.metrics.MeterRegistryCustomizer;
2930
import org.springframework.boot.context.properties.ConfigurationProperties;
3031
import org.springframework.context.annotation.Bean;
3132
import org.springframework.context.annotation.Configuration;
3233
import org.springframework.context.annotation.Scope;
3334

3435
import io.micrometer.core.instrument.MeterRegistry;
35-
import io.micrometer.spring.autoconfigure.MeterRegistryCustomizer;
3636
import io.vertx.core.Vertx;
3737
import io.vertx.core.VertxOptions;
3838

services/device-connection/src/main/java/org/eclipse/hono/deviceconnection/infinispan/ApplicationConfig.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@
2727
import org.infinispan.client.hotrod.RemoteCacheManager;
2828
import org.springframework.beans.factory.annotation.Qualifier;
2929
import org.springframework.beans.factory.config.ObjectFactoryCreatingFactoryBean;
30+
import org.springframework.boot.actuate.autoconfigure.metrics.MeterRegistryCustomizer;
3031
import org.springframework.boot.context.properties.ConfigurationProperties;
3132
import org.springframework.context.annotation.Bean;
3233
import org.springframework.context.annotation.Configuration;
3334
import org.springframework.context.annotation.Scope;
3435

3536
import io.micrometer.core.instrument.MeterRegistry;
36-
import io.micrometer.spring.autoconfigure.MeterRegistryCustomizer;
3737
import io.opentracing.Tracer;
3838
import io.opentracing.contrib.tracerresolver.TracerResolver;
3939
import io.opentracing.noop.NoopTracerFactory;

services/device-registry/src/main/java/org/eclipse/hono/deviceregistry/ApplicationConfig.java

+1-5
Original file line numberDiff line numberDiff line change
@@ -24,30 +24,26 @@
2424
import org.eclipse.hono.service.HealthCheckServer;
2525
import org.eclipse.hono.service.VertxBasedHealthCheckServer;
2626
import org.eclipse.hono.service.credentials.CredentialsAmqpEndpoint;
27-
2827
import org.eclipse.hono.service.deviceconnection.DeviceConnectionAmqpEndpoint;
29-
3028
import org.eclipse.hono.service.management.credentials.CredentialsManagementHttpEndpoint;
3129
import org.eclipse.hono.service.management.credentials.CredentialsManagementService;
3230
import org.eclipse.hono.service.management.device.DeviceManagementHttpEndpoint;
3331
import org.eclipse.hono.service.management.device.DeviceManagementService;
3432
import org.eclipse.hono.service.management.tenant.TenantManagementHttpEndpoint;
35-
3633
import org.eclipse.hono.service.management.tenant.TenantManagementService;
37-
3834
import org.eclipse.hono.service.metric.MetricsTags;
3935
import org.eclipse.hono.service.registration.RegistrationAmqpEndpoint;
4036
import org.eclipse.hono.service.tenant.TenantAmqpEndpoint;
4137
import org.eclipse.hono.util.Constants;
4238
import org.springframework.beans.factory.annotation.Qualifier;
39+
import org.springframework.boot.actuate.autoconfigure.metrics.MeterRegistryCustomizer;
4340
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
4441
import org.springframework.boot.context.properties.ConfigurationProperties;
4542
import org.springframework.context.annotation.Bean;
4643
import org.springframework.context.annotation.Configuration;
4744
import org.springframework.context.annotation.Scope;
4845

4946
import io.micrometer.core.instrument.MeterRegistry;
50-
import io.micrometer.spring.autoconfigure.MeterRegistryCustomizer;
5147
import io.opentracing.Tracer;
5248
import io.opentracing.contrib.tracerresolver.TracerResolver;
5349
import io.opentracing.noop.NoopTracerFactory;

0 commit comments

Comments
 (0)