Fast-Path String and Vector Hash Code Methods on Power

Fast-path ArraysSupport.vectorizedHashCode and String.hashCodeImplCompressed
methods on Power. The String.hashCodeImplDecompressed method has already
been fast-pathed. Since the other methods use the same logic, the existing
code can be modified to recognise and accomodate them.

Signed-off-by: Luke Li <[email protected]>

Author: luke-li-2003

runtime/compiler/optimizer/InlinerTempForJ9.cpp

@@ -5592,26 +5592,16 @@ TR_J9InlinerPolicy::supressInliningRecognizedInitialCallee(TR_CallSite* callsite
          return false;
          }
       case TR::java_lang_String_hashCodeImplDecompressed:
-         /*
-          * X86 and z want to avoid inlining both java_lang_String_hashCodeImplDecompressed and java_lang_String_hashCodeImplCompressed
-          * so they can be recognized and replaced with a custom fast implementation.
-          * Power currently only has the custom fast implementation for java_lang_String_hashCodeImplDecompressed.
-          * As a result, Power only wants to prevent inlining of java_lang_String_hashCodeImplDecompressed.
-          * When Power gets a fast implementation of TR::java_lang_String_hashCodeImplCompressed, this case can be merged into the case
-          * for java_lang_String_hashCodeImplCompressed instead of using a fallthrough.
-          */
-         if (!TR::Compiler->om.canGenerateArraylets() && !TR::Compiler->om.isOffHeapAllocationEnabled() &&
-             comp->target().cpu.isPower() && comp->target().cpu.isAtLeast(OMR_PROCESSOR_PPC_P8) && comp->target().cpu.supportsFeature(OMR_FEATURE_PPC_HAS_VSX) && !comp->compileRelocatableCode())
-               {
-               return true;
-               }
-         // Intentional fallthrough here.
       case TR::java_lang_String_hashCodeImplCompressed:
+         // X86, Z and Power have custom fast implementations for these 2 methods
+         // so their inlining should be avoided.
+         {
          if (comp->cg()->getSupportsInlineStringHashCode())
             {
             return true;
             }
          break;
+         }
       case TR::jdk_internal_util_ArraysSupport_vectorizedHashCode:
          {
          if (comp->cg()->getSupportsInlineVectorizedHashCode())

runtime/compiler/p/codegen/J9CodeGenerator.cpp

@@ -123,6 +123,16 @@ J9::Power::CodeGenerator::initialize()
    if (!comp->getOption(TR_DisableReadMonitors))
       cg->setSupportsReadOnlyLocks();
 
+   if (!TR::Compiler->om.canGenerateArraylets()
+         && !TR::Compiler->om.isOffHeapAllocationEnabled()
+         && comp->target().cpu.isAtLeast(OMR_PROCESSOR_PPC_P8)
+         && comp->target().cpu.supportsFeature(OMR_FEATURE_PPC_HAS_VSX)
+      )
+      {
+      cg->setSupportsInlineStringHashCode();
+      cg->setSupportsInlineVectorizedHashCode();
+      }
+
    static bool disableTLHPrefetch = (feGetEnv("TR_DisableTLHPrefetch") != NULL);
 
    // Enable software prefetch of the TLH and configure the TLH prefetching