Skip to content

Commit 303d72c

Browse files
pshiptonpshipton
authored
Merge pull request #22651 from babsingh/v0.56.0-release
(0.56) Revert "RAM Class: Per-kind segment allocation and sizing"
2 parents 1cb3708 + c852280 commit 303d72c

File tree

5 files changed

+298
-733
lines changed

5 files changed

+298
-733
lines changed

‎runtime/jcl/common/mgmtmemory.c‎

Lines changed: 53 additions & 97 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ static UDATA getIndexFromGCID(J9JavaLangManagementData *mgmt, UDATA id);
3232
jobject JNICALL
3333
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getHeapMemoryUsageImpl(JNIEnv *env, jobject beanInstance, jclass memoryUsage, jobject memUsageConstructor)
3434
{
35-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
35+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
3636
jlong used = 0;
3737
jlong committed = 0;
3838
jmethodID ctor = NULL;
@@ -48,59 +48,10 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getHeapMemoryUsageIm
4848
return (*env)->NewObject(env, memoryUsage, ctor, (jlong)javaVM->managementData->initialHeapSize, used, committed, (jlong)javaVM->managementData->maximumHeapSize);
4949
}
5050

51-
/**
52-
* @brief Subtracts sizes of all free list blocks from the accumulator.
53-
*
54-
* Iterates through tiny, small, and large block lists in
55-
* j9RAMClassFreeListsPtr and subtracts each block's size from used.
56-
*
57-
* @param j9RAMClassFreeListsPtr Pointer to RAM class free-lists (may be NULL).
58-
* @param used Pointer to a jlong accumulator decremented by block sizes.
59-
*/
60-
void
61-
subtractFreeListBlocks(J9RAMClassFreeLists* j9RAMClassFreeListsPtr, jlong *used)
62-
{
63-
if (NULL != j9RAMClassFreeListsPtr) {
64-
J9RAMClassFreeListBlock *ramClassTinyBlockFreeListPtr = j9RAMClassFreeListsPtr->ramClassTinyBlockFreeList;
65-
J9RAMClassFreeListBlock *ramClassSmallBlockFreeListPtr = j9RAMClassFreeListsPtr->ramClassSmallBlockFreeList;
66-
J9RAMClassFreeListBlock *ramClassLargeBlockFreeListPtr = j9RAMClassFreeListsPtr->ramClassLargeBlockFreeList;
67-
while (NULL != ramClassTinyBlockFreeListPtr) {
68-
*used -= ramClassTinyBlockFreeListPtr->size;
69-
ramClassTinyBlockFreeListPtr = ramClassTinyBlockFreeListPtr->nextFreeListBlock;
70-
}
71-
while (NULL != ramClassSmallBlockFreeListPtr) {
72-
*used -= ramClassSmallBlockFreeListPtr->size;
73-
ramClassSmallBlockFreeListPtr = ramClassSmallBlockFreeListPtr->nextFreeListBlock;
74-
}
75-
while (NULL != ramClassLargeBlockFreeListPtr) {
76-
*used -= ramClassLargeBlockFreeListPtr->size;
77-
ramClassLargeBlockFreeListPtr = ramClassLargeBlockFreeListPtr->nextFreeListBlock;
78-
}
79-
}
80-
}
81-
82-
/**
83-
* @brief Subtracts the size of each UDATA block in a chain from the accumulator.
84-
*
85-
* Walks a chain of UDATA blocks starting at ramClassUDATABlockFreeListPtr
86-
* and subtracts sizeof(UDATA) for each from used.
87-
*
88-
* @param ramClassUDATABlockFreeListPtr Head of UDATA block chain (may be NULL).
89-
* @param used Pointer to a jlong accumulator decremented by block count * sizeof(UDATA).
90-
*/
91-
void
92-
subtractUDATABlockChain(UDATA *ramClassUDATABlockFreeListPtr, jlong *used)
93-
{
94-
while (NULL != ramClassUDATABlockFreeListPtr) {
95-
*used -= sizeof(UDATA);
96-
ramClassUDATABlockFreeListPtr = *(UDATA **)ramClassUDATABlockFreeListPtr;
97-
}
98-
}
99-
10051
jobject JNICALL
10152
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getNonHeapMemoryUsageImpl(JNIEnv *env, jobject beanInstance, jclass memoryUsage, jobject memUsageConstructor)
10253
{
103-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
54+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
10455
J9JavaLangManagementData *mgmt = javaVM->managementData;
10556
jlong used = 0;
10657
jlong committed = 0;
@@ -125,21 +76,26 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getNonHeapMemoryUsag
12576
omrthread_monitor_enter(javaVM->classTableMutex);
12677
classLoader = javaVM->internalVMFunctions->allClassLoadersStartDo(&walkState, javaVM, 0);
12778
while (NULL != classLoader) {
128-
J9RAMClassFreeLists *sub4gBlockPtr = &classLoader->sub4gBlock;
129-
J9RAMClassFreeLists *frequentlyAccessedBlockPtr = &classLoader->frequentlyAccessedBlock;
130-
J9RAMClassFreeLists *inFrequentlyAccessedBlockPtr = &classLoader->inFrequentlyAccessedBlock;
131-
UDATA *ramClassSub4gUDATABlockFreeListPtr = sub4gBlockPtr->ramClassUDATABlockFreeList;
132-
UDATA *ramClassFreqUDATABlockFreeListPtr = frequentlyAccessedBlockPtr->ramClassUDATABlockFreeList;
133-
UDATA *ramClassInFreqUDATABlockFreeListPtr = inFrequentlyAccessedBlockPtr->ramClassUDATABlockFreeList;
134-
135-
subtractUDATABlockChain(ramClassSub4gUDATABlockFreeListPtr, &used);
136-
subtractUDATABlockChain(ramClassFreqUDATABlockFreeListPtr, &used);
137-
subtractUDATABlockChain(ramClassInFreqUDATABlockFreeListPtr, &used);
138-
139-
subtractFreeListBlocks(sub4gBlockPtr, &used);
140-
subtractFreeListBlocks(frequentlyAccessedBlockPtr, &used);
141-
subtractFreeListBlocks(inFrequentlyAccessedBlockPtr, &used);
142-
79+
UDATA *udataFreeListBlock = classLoader->ramClassUDATABlockFreeList;
80+
J9RAMClassFreeListBlock *tinyFreeListBlock = classLoader->ramClassTinyBlockFreeList;
81+
J9RAMClassFreeListBlock *smallFreeListBlock = classLoader->ramClassSmallBlockFreeList;
82+
J9RAMClassFreeListBlock *largeFreeListBlock = classLoader->ramClassLargeBlockFreeList;
83+
while (NULL != udataFreeListBlock) {
84+
used -= sizeof(UDATA);
85+
udataFreeListBlock = *(UDATA **) udataFreeListBlock;
86+
}
87+
while (NULL != tinyFreeListBlock) {
88+
used -= tinyFreeListBlock->size;
89+
tinyFreeListBlock = tinyFreeListBlock->nextFreeListBlock;
90+
}
91+
while (NULL != smallFreeListBlock) {
92+
used -= smallFreeListBlock->size;
93+
smallFreeListBlock = smallFreeListBlock->nextFreeListBlock;
94+
}
95+
while (NULL != largeFreeListBlock) {
96+
used -= largeFreeListBlock->size;
97+
largeFreeListBlock = largeFreeListBlock->nextFreeListBlock;
98+
}
14399
classLoader = javaVM->internalVMFunctions->allClassLoadersNextDo(&walkState);
144100
}
145101
javaVM->internalVMFunctions->allClassLoadersEndDo(&walkState);
@@ -210,7 +166,7 @@ jint JNICALL
210166
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getObjectPendingFinalizationCountImpl(JNIEnv *env, jobject beanInstance)
211167
{
212168
#if defined(J9VM_GC_FINALIZATION)
213-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
169+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
214170
return (jint)javaVM->memoryManagerFunctions->j9gc_get_objects_pending_finalization_count(javaVM);
215171
#else
216172
return (jint)0;
@@ -220,15 +176,15 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getObjectPendingFina
220176
jboolean JNICALL
221177
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_isVerboseImpl(JNIEnv *env, jobject beanInstance)
222178
{
223-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
179+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
224180

225181
return VERBOSE_GC == (VERBOSE_GC & javaVM->verboseLevel) ;
226182
}
227183

228184
void JNICALL
229185
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_setVerboseImpl(JNIEnv *env, jobject beanInstance, jboolean flag)
230186
{
231-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
187+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
232188
J9VerboseSettings verboseOptions;
233189

234190
memset(&verboseOptions, 0, sizeof(J9VerboseSettings));
@@ -241,7 +197,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_setVerboseImpl(JNIEn
241197
void JNICALL
242198
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_createMemoryManagers(JNIEnv *env, jobject beanInstance)
243199
{
244-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
200+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
245201
jclass memBean = NULL;
246202
jstring childName = NULL;
247203
jmethodID helperID = NULL;
@@ -278,7 +234,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_createMemoryManagers
278234
}
279235

280236
for (idx = 0; idx < mgmt->supportedCollectors; ++idx) {
281-
id = (jint)mgmt->garbageCollectors[idx].id;
237+
id = (jint) mgmt->garbageCollectors[idx].id;
282238
childName = (*env)->NewStringUTF(env, mgmt->garbageCollectors[idx].name);
283239
if (NULL == childName) {
284240
return;
@@ -291,7 +247,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_createMemoryManagers
291247
void JNICALL
292248
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_createMemoryPools(JNIEnv *env, jobject beanInstance)
293249
{
294-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
250+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
295251
jclass memBean = NULL;
296252
jstring childName = NULL;
297253
jmethodID helperID = NULL;
@@ -311,7 +267,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_createMemoryPools(JN
311267

312268
/* Heap Memory Pools */
313269
for (idx = 0; idx < mgmt->supportedMemoryPools; ++idx) {
314-
id = (jint)mgmt->memoryPools[idx].id;
270+
id = (jint) mgmt->memoryPools[idx].id;
315271
childName = (*env)->NewStringUTF(env, mgmt->memoryPools[idx].name);
316272
if (NULL == childName) {
317273
return;
@@ -325,7 +281,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_createMemoryPools(JN
325281

326282
/* NonHeap Memory Pools */
327283
for (idx = 0; idx < mgmt->supportedNonHeapMemoryPools; ++idx) {
328-
id = (jint)mgmt->nonHeapMemoryPools[idx].id;
284+
id = (jint) mgmt->nonHeapMemoryPools[idx].id;
329285
childName = (*env)->NewStringUTF(env, mgmt->nonHeapMemoryPools[idx].name);
330286
if (NULL == childName) {
331287
return;
@@ -341,15 +297,15 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_createMemoryPools(JN
341297
jlong JNICALL
342298
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getMaxHeapSizeLimitImpl(JNIEnv *env, jobject beanInstance)
343299
{
344-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
300+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
345301

346302
return javaVM->memoryManagerFunctions->j9gc_get_maximum_heap_size(javaVM);
347303
}
348304

349305
jlong JNICALL
350306
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getMaxHeapSizeImpl(JNIEnv *env, jobject beanInstance)
351307
{
352-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
308+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
353309
UDATA softmx = javaVM->memoryManagerFunctions->j9gc_get_softmx(javaVM);
354310

355311
/* if no softmx has been set, report -Xmx instead as it is the current max heap size */
@@ -362,15 +318,15 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getMaxHeapSizeImpl(J
362318
jlong JNICALL
363319
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getMinHeapSizeImpl(JNIEnv *env, jobject beanInstance)
364320
{
365-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
321+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
366322

367323
return javaVM->memoryManagerFunctions->j9gc_get_initial_heap_size(javaVM);
368324
}
369325

370326
void JNICALL
371327
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_setMaxHeapSizeImpl(JNIEnv *env, jobject beanInstance, jlong newsoftmx)
372328
{
373-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
329+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
374330

375331
javaVM->memoryManagerFunctions->j9gc_set_softmx(javaVM, (UDATA)newsoftmx);
376332
}
@@ -381,7 +337,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_setSharedClassCacheS
381337
jboolean ret = JNI_FALSE;
382338

383339
#if defined(J9VM_OPT_SHARED_CLASSES)
384-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
340+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
385341

386342
if (javaVM->sharedClassConfig) {
387343
if (0 != javaVM->sharedClassConfig->setMinMaxBytes(javaVM, (U_32)value, -1, -1, -1, -1)) {
@@ -398,7 +354,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_setSharedClassCacheM
398354
jboolean ret = JNI_FALSE;
399355

400356
#if defined(J9VM_OPT_SHARED_CLASSES)
401-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
357+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
402358

403359
if (javaVM->sharedClassConfig) {
404360
if (0 != javaVM->sharedClassConfig->setMinMaxBytes(javaVM, (U_32)-1, (I_32)value, -1, -1, -1)) {
@@ -415,7 +371,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_setSharedClassCacheM
415371
jboolean ret = JNI_FALSE;
416372

417373
#if defined(J9VM_OPT_SHARED_CLASSES)
418-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
374+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
419375

420376
if (javaVM->sharedClassConfig) {
421377
if (0 != javaVM->sharedClassConfig->setMinMaxBytes(javaVM, (U_32)-1, -1, (I_32)value, -1, -1)) {
@@ -432,7 +388,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_setSharedClassCacheM
432388
jboolean ret = JNI_FALSE;
433389

434390
#if defined(J9VM_OPT_SHARED_CLASSES)
435-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
391+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
436392

437393
if (javaVM->sharedClassConfig) {
438394
if (0 != javaVM->sharedClassConfig->setMinMaxBytes(javaVM, (U_32)-1, -1, -1, (I_32)value, -1)) {
@@ -449,7 +405,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_setSharedClassCacheM
449405
jboolean ret = JNI_FALSE;
450406

451407
#if defined(J9VM_OPT_SHARED_CLASSES)
452-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
408+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
453409

454410
if (javaVM->sharedClassConfig) {
455411
if (0 != javaVM->sharedClassConfig->setMinMaxBytes(javaVM, (U_32)-1, -1, -1, -1, (I_32)value)) {
@@ -466,7 +422,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getSharedClassCacheS
466422
U_32 ret = 0;
467423

468424
#if defined(J9VM_OPT_SHARED_CLASSES)
469-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
425+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
470426

471427
if (javaVM->sharedClassConfig) {
472428
javaVM->sharedClassConfig->getUnstoredBytes(javaVM, &ret, NULL, NULL);
@@ -481,7 +437,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getSharedClassCacheM
481437
U_32 ret = 0;
482438

483439
#if defined(J9VM_OPT_SHARED_CLASSES)
484-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
440+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
485441

486442
if (javaVM->sharedClassConfig) {
487443
javaVM->sharedClassConfig->getUnstoredBytes(javaVM, NULL, &ret, NULL);
@@ -496,7 +452,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getSharedClassCacheM
496452
U_32 ret = 0;
497453

498454
#if defined(J9VM_OPT_SHARED_CLASSES)
499-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
455+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
500456

501457
if (javaVM->sharedClassConfig) {
502458
javaVM->sharedClassConfig->getUnstoredBytes(javaVM, NULL, NULL, &ret);
@@ -514,7 +470,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_isSetMaxHeapSizeSupp
514470
jstring JNICALL
515471
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getGCModeImpl(JNIEnv *env, jobject beanInstance)
516472
{
517-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
473+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
518474
const char *gcMode = javaVM->memoryManagerFunctions->j9gc_get_gcmodestring(javaVM);
519475

520476
if (NULL != gcMode) {
@@ -527,7 +483,7 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getGCModeImpl(JNIEnv
527483
jlong JNICALL
528484
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getGCMainThreadCpuUsedImpl(JNIEnv *env, jobject beanInstance)
529485
{
530-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
486+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
531487
J9JavaLangManagementData *mgmt = javaVM->managementData;
532488
jlong result = 0;
533489

@@ -541,12 +497,12 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getGCMainThreadCpuUs
541497
jlong JNICALL
542498
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getGCWorkerThreadsCpuUsedImpl(JNIEnv *env, jobject beanInstance)
543499
{
544-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
500+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
545501
J9JavaLangManagementData *mgmt = javaVM->managementData;
546502
jlong result = 0;
547503

548504
omrthread_rwmutex_enter_read(mgmt->managementDataLock);
549-
result = (jlong)mgmt->gcWorkerCpuTime;
505+
result = (jlong) mgmt->gcWorkerCpuTime;
550506
omrthread_rwmutex_exit_read(mgmt->managementDataLock);
551507

552508
return result;
@@ -555,12 +511,12 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getGCWorkerThreadsCp
555511
jint JNICALL
556512
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getMaximumGCThreadsImpl(JNIEnv *env, jobject beanInstance)
557513
{
558-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
514+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
559515
J9JavaLangManagementData *mgmt = javaVM->managementData;
560516
jint result = 0;
561517

562518
omrthread_rwmutex_enter_read(mgmt->managementDataLock);
563-
result = (jint)mgmt->gcMaxThreads;
519+
result = (jint) mgmt->gcMaxThreads;
564520
omrthread_rwmutex_exit_read(mgmt->managementDataLock);
565521

566522
return result;
@@ -569,12 +525,12 @@ Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getMaximumGCThreadsI
569525
jint JNICALL
570526
Java_com_ibm_java_lang_management_internal_MemoryMXBeanImpl_getCurrentGCThreadsImpl(JNIEnv *env, jobject beanInstance)
571527
{
572-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
528+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
573529
J9JavaLangManagementData *mgmt = javaVM->managementData;
574530
jint result = 0;
575531

576532
omrthread_rwmutex_enter_read(mgmt->managementDataLock);
577-
result = (jint)mgmt->gcCurrentThreads;
533+
result = (jint) mgmt->gcCurrentThreads;
578534
omrthread_rwmutex_exit_read(mgmt->managementDataLock);
579535

580536
return result;
@@ -585,7 +541,7 @@ void JNICALL
585541
Java_com_ibm_lang_management_internal_MemoryNotificationThread_processNotificationLoop(JNIEnv *env, jobject threadInstance)
586542
{
587543
/* currently, the only notification queue is for the heap */
588-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
544+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
589545
J9JavaLangManagementData *mgmt = javaVM->managementData;
590546
jclass threadClass = NULL;
591547
jclass stringClass = NULL;
@@ -770,7 +726,7 @@ Java_com_ibm_lang_management_internal_MemoryNotificationThread_processNotificati
770726
} else {
771727
/* dispatch usage threshold Notification */
772728
memoryPoolUsageThreshold *usageThreshold = notification->usageThreshold;
773-
idx = (U_32)getIndexFromMemoryPoolID(mgmt, usageThreshold->poolID);
729+
idx = (U_32) getIndexFromMemoryPoolID(mgmt, usageThreshold->poolID);
774730
pool = &mgmt->memoryPools[idx];
775731
poolName = poolNames[idx];
776732
if (THRESHOLD_EXCEEDED == notification->type) {
@@ -832,7 +788,7 @@ void JNICALL
832788
Java_com_ibm_lang_management_internal_MemoryNotificationThreadShutdown_sendShutdownNotification(JNIEnv *env, jobject instance)
833789
{
834790
/* currently, the only queue is the heap usage notification queue */
835-
J9JavaVM *javaVM = ((J9VMThread *)env)->javaVM;
791+
J9JavaVM *javaVM = ((J9VMThread *) env)->javaVM;
836792
J9JavaLangManagementData *mgmt = javaVM->managementData;
837793
J9MemoryNotification *notification = NULL;
838794
J9MemoryNotification *next = NULL;

0 commit comments

Comments
 (0)