Add N&N entry for JDT JUnit 6 support #437
Conversation
|
I wonder if we should mention the potential conflicts between JUnit 5 and JUnit 6 in the PDE 4.38 N&N entry? Since Eclipse 4.38 will contain both versions and likely plug-in maintainers will run into the issue of mixed versions (that is at least so far not self-explanatory)... |
Yes, we should. Ideally with some hints how to find & resolve the "wrong" dependencies issue. |
trancexpress
force-pushed
the
gh436
branch
2 times, most recently
from
adf250b to
dc948c7
Compare
| --- | ||
| ## JUnit Plug-in Test Launch | ||
|
|
||
| ### JUnit 5 and JUnit 6 conflicts in Eclipse 4.38+ |
There was a problem hiding this comment.
@HannesWell @laeubi corrections/proposals for the text here are very welcome.
|
|
||
| #### Add JUnit 6 library to the build path: | ||
|
|
||
| The JUnit Test Case wizard offers to add it while creating a new JUnit Jupiter test: |
There was a problem hiding this comment.
While reading this I wonder if we should propose this for projects configured for Java < 17? Also here we should mention, that JUnit 6 only works with Java >= 17.
There was a problem hiding this comment.
We could do this, see org.eclipse.jdt.internal.junit.ui.JUnitClasspathFixProcessor.getFixImportProposals(IJavaProject, String) which takes the project...
It would take some effort though, determining the classpath JRE version... Considering the user can define whatever they want.
Are you sure we should invest time in this? E.g. JUnit 5 allegedly requires Java 8, but there is no check for that.
We could make it low effort, I guess? Look for JavaSE-N container, evaluate N? But I'm not sure its worth the trouble. Especially considering we don't do such checks anywhere else where JUnit 6 is involved.
iloveeclipse
left a comment
iloveeclipse
left a comment
There was a problem hiding this comment.
Let's merge to spread the news about it.
We can/will improve that anyway.
|
Yes, sorry. Too much to do and too much to track. Toward the end of the release, I generally sweep through all the N&N and tweak/improve a few things here and there and to make sure they looks relatively uniform. Thanks for the additional content! |
4 participants
Fixes: #436