New workspace file unexpectedly populated with settings #16613
Description
Bug Description:
I recently created a new multi-root workspace using the 'Add Folder to Workspace' command, and when I then opened the newly created workspace file, it contained about 200 lines of settings, including a copy of all of Theia's launch configs.
Steps to Reproduce:
- Open one folder as a single-folder workspace (I started with this repo)
- Use the 'Add folder to workspace' command to add another folder.
- There will be a prompt to save your new workspace as a workspace file.
- Say yes and save the file.
- Open the file. (e.g. by going to preferences, selecting workspace scope, then opening the JSON)
- Observe that it contains a
settingsfield.
Note
This deviates from my expectations in two ways. Most significantly in that the file contains more than a specification of the folders contained in the workspace - on creation, it shouldn't specify any settings. Secondly, that at (3) there is a prompt to save the workspace file. I'd expect to be left alone with an untitled workspace until closing the application or changing workspaces, at which point the save prompt would appear. That's a matter of UX judgment, but the current arrangement does differ from VSCode's behavior and, I think, the behavior of earlier versions of Theia.
Additional Information
- Operating System: MacOS Tahoe
- Theia Version: 9b2e07f