Skip to content

Task input prompt closes when clicking outside the dialog #17894

Description

@fengxi-mao-mchp

Steps to reproduce:

  1. Create a tasks.json under a .theia folder
  2. Add a task which takes in an input, for example, the file I reproduced the bug with is:
{
  // See https://go.microsoft.com/fwlink/?LinkId=733558
  // for the documentation about the tasks.json format
  "version": "2.0.0",
  "tasks": [
    {
      "label": "echo",
      "type": "shell",
      "command": "echo Hello ${input:programmer_id}"
    }
  ],
  "inputs": [
    {
      "id": "programmer_id",
      "type": "promptString",
      "description": "FlashPro programmer serial number (e.g. S2011JOH9N). If unsure, run ${PFSDK_ROOT}/modules/debug/fpserver/run_fpserver.sh (or .cmd for Windows) --list"
    }
  ]
}
  1. Run the task via the command palette
  2. When prompted to enter the input, click away, anywhere on the screen

What happens:

The task gets run with no input passed in.

Expected behavior:

Not sure if this is supposed to be the expected behavior, but I feel like the behavior which VS Code has is more intuitive. Nothing happens unless the user either presses Enter or Escape. Clicking away does not trigger the task.

Additional information:

  • Operating System: Windows 11
  • Theia Version: 1.73.100

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    quick-openissues related to the quick-openui/uxissues related to user interface / user experience

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions