Skip to content

Commit b0bbed4

Browse files
committed
release: update to 2.5.4 with guest login fixes and anonymous SMB3 handling
- Bumped versionCode to 20504 and version to 2.5.4. - Resolved guest login issues and SMB3 crash during anonymous sessions (issue #32). - Added integration tests for Samba guest/anonymous login scenarios. - Updated CHANGELOG for version 2.5.4.
1 parent f13b598 commit b0bbed4

3 files changed

Lines changed: 13 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,17 @@ All notable changes to SambaLite will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [2.5.4] - 2026-07-10
9+
10+
### Fixed
11+
- **Guest login fails (issue #32)**: Connections without username and password previously used `AuthenticationContext.guest()`, which sends the username `Guest`. Samba servers with a guest-accessible share but without `map to guest = Bad User` (the Samba default is `map to guest = Never`) reject this login with `NT_STATUS_NO_SUCH_USER` / `NT_STATUS_LOGON_FAILURE`. SambaLite now performs a true anonymous login (empty username and password), matching the behavior of `mount.cifs -o guest`.
12+
- **SMB3 crash on anonymous sessions**: Anonymous/guest connections are now restricted to SMB2 dialects (SMB 2.1 / 2.0.2). SMBJ 0.14.0 crashes with a `NullPointerException` when deriving SMB3 signing keys for anonymous sessions if the server does not set the IS_NULL/IS_GUEST session flags (hierynomus/smbj#792); SMB3 signing/encryption offers no protection for anonymous sessions anyway.
13+
14+
### Added
15+
- **Tests**: New `GuestLoginIntegrationTest` reproducing the reporter's setup (Samba 4.23.x, guest-accessible share, no `map to guest` mapping) against a real Samba container, verifying that anonymous login succeeds where the old `guest()` login fails, and that the documented `map to guest = Bad User` workaround still works.
16+
17+
If you like this update, support SambaLite here: https://ko-fi.com/egdelshttps://www.paypal.com/paypalme/egdels
18+
819
## [2.5.3] - 2026-07-07
920

1021
### Added

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ android {
2020
minSdk 28
2121
targetSdk = 36
2222

23-
versionCode 20503
23+
versionCode 20504
2424
versionName project.version.toString()
2525
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
2626
}

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ allprojects {
1515
// Defines the group ID used for all projects
1616
group = 'de.schliweb.sambalite'
1717
// F-Droid expects this exact pattern: version = 'x.x.x'
18-
version = '2.5.3'
18+
version = '2.5.4'
1919

2020
repositories {
2121
google()

0 commit comments

Comments
 (0)