browser: true ignored when used with @rollup/plugin-node-resolve

[BryceMehring]

Same issue as rollup/plugins#1267.

I'm getting

(!) Unresolved dependencies
https://rollupjs.org/troubleshooting/#warning-treating-module-as-external-dependency
zlib (imported by "zlib?commonjs-external")
http (imported by "http?commonjs-external")
https (imported by "https?commonjs-external")
assert (imported by "assert?commonjs-external")
stream (imported by "stream?commonjs-external")

What fixes this problem is running this plugin as:

{
  ...esbuild(),
  resolveId: undefined,
}

[tbrannam]

In my environment I needed to replace resolveId a little differently.

{
  ...esbuild(),
  resolveId: () => null,
}

[JanErikGunnar]

I think we are having this issue as well. In our case it is more complicated because blanket replacing resolveId breaks other dependencies, so we have to do something like:

    {
      ...esbuildPlugin,
      resolveId: (importee, ...otherParams) => (importee.endsWith('.js') ? null : esbuildPlugin.resolveId(importee, ...otherParams)),
    },

The package we are ultimately trying to import is axios 1.7.7.
It worked with rollup-plugin-esbuild <= 4.9.1. axios is using JS files and those files were ignored in older versions of this plugin.