Skip to content

Commit 7efce37

Browse files
author
Mike Harris
committed
Add type="button" to option group collapse
Fix #872 Cleanup readme a little
1 parent edc57e0 commit 7efce37

File tree

6 files changed

+61
-39
lines changed

6 files changed

+61
-39
lines changed

Gemfile.lock

+1-1
Original file line numberDiff line numberDiff line change
@@ -246,4 +246,4 @@ DEPENDENCIES
246246
github-pages
247247

248248
BUNDLED WITH
249-
1.16.2
249+
2.1.2

README.MD

+11-6
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,28 @@
22

33
MultiSelect progessively enhances an ordinary multiple select control into elegant drop down list of checkboxes, stylable with ThemeRoller.
44

5-
### Demo Page
5+
## Demo Page
6+
67
Check out the demo page [here!](https://ehynds.github.io/jquery-ui-multiselect-widget/)
78

8-
### Version 3
9-
Version 3 of the widget is available in pre-release. This introduces a lot of new features and substantial performance imrovements.
9+
## Version 3
10+
11+
Version 3 of the widget is available. This introduces a lot of new features and substantial performance imrovements.
1012

1113
Check out the [release notes](https://github.com/ehynds/jquery-ui-multiselect-widget/releases/tag/3.0.0) for an exact list of changes and see the [wiki](https://github.com/ehynds/jquery-ui-multiselect-widget/wiki/Migrating-to-Version-3) for the information you may need to switch over. The main wiki will be getting updates for the new features and changed options.
1214

13-
### Requirements
15+
## Requirements
16+
1417
The [usage](https://github.com/ehynds/jquery-ui-multiselect-widget/wiki/Usage) section of the Wiki specifies the widget's dependencies.
1518

16-
# License
19+
## License
1720

1821
MultiSelect is dual-licensed under the [GPL 2 license](https://github.com/ehynds/jquery-ui-multiselect-widget/blob/master/GPL-LICENSE) and the [MIT license](https://github.com/ehynds/jquery-ui-multiselect-widget/blob/master/MIT-LICENSE).
1922

20-
# Contributing
23+
## Contributing
2124

2225
When submitting a pull request, please describe the change you are making - preferably with a use case. Unit tests are now (14 March 2016) required for the pull to be merged.
2326

2427
Please do not submit minified code in your pull request, that tends to cause merge conflicts.
28+
29+
You can test the demo pages locally by navigating to the `docs` directory and running `bundle install && bundle exec jekyll server`.

docs/js/widget.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

+45-28
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "jquery-ui-multiselect-widget",
33
"description": "MultiSelect progessively enhances an ordinary multiple select control into elegant drop down list of checkboxes, stylable with ThemeRoller.",
4-
"version": "3.0.0",
4+
"version": "3.0.1",
55
"license": "MIT or GPL-2.0",
66
"author": "Eric Hynds",
77
"contributors": [

src/jquery.multiselect.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@
279279
}
280280

281281
if (this.options.header.constructor == Object) {
282-
var options = Object.keys(this.options.header)
282+
var options = Object.keys(this.options.header);
283283
for (var x = 0; x < options.length; x++) {
284284
var displayText = options[x];
285285
var linkInfoKey = this.options.header[displayText];
@@ -532,7 +532,7 @@
532532
// Build the list section for this optgroup, complete w/ option inputs...
533533
var $collapseButton = !!self.options.groupsCollapsable
534534
? $( document.createElement('button') )
535-
.attr({'title': self.linkInfo.collapse.title})
535+
.attr({'title': self.linkInfo.collapse.title, 'type': 'button'})
536536
.addClass('ui-state-default ui-corner-all ui-multiselect-collapser')
537537
.html(self.linkInfo.collapse.icon)
538538
: null;

0 commit comments

Comments
 (0)