security: restrict workflow permissions to minimum required #2206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set workflow-level permissions to 'contents: read' (minimum) and grant additional permissions only to jobs that need them: - clang-tidy-iwyu: contents: write, pull-requests: write (for creating IWYU fix PRs and posting comments) - llvm-cov: statuses: write (for posting code coverage commit statuses) - trigger-container: statuses: write (for posting GitLab CI status) - deploy-docs: pages: write, id-token: write, pull-requests: write (for deploying GitHub Pages and posting comments) This addresses code scanning security alert about overly permissive workflow permissions by applying the principle of least privilege. Fixes: GitHub Code Scanning Alert #21
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances workflow security by implementing the principle of least privilege for GitHub Actions permissions. It restricts the default workflow permissions to read-only and grants elevated permissions only to specific jobs that require them.
- Set workflow-level permissions to
contents: read(minimum required) - Added granular job-level permissions for jobs that need write access
- Included clear comments documenting why each permission is needed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Set workflow-level permissions to 'contents: read' (minimum) and grant additional permissions only to jobs that need them:
This addresses code scanning security alert about overly permissive workflow permissions by applying the principle of least privilege.
Fixes: Various GitHub Code Scanning Alerts, https://github.com/eic/EICrecon/security/code-scanning
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.