Skip to content

if upgrading, first delete the full "node" dir #994

@jcompagner

Description

@jcompagner

when i did go from Node 16.2 to 1.6.6 it did do the update to that version
(this is with npm just included, not an extra npm install)

but then weird npm-cli errors came up
when i then really just first delete the "node" dir and let the plugin install node again everything was fine

if i look into:

https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeInstaller.java

i also don't really see a full delete first..

NpmInstaller i do see that that it first does delete stuff.
But not when npm is provided by node i think it is this code:

https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeInstaller.java#L189

are we needing there 1 line of code that deletes first if it is there the full target dir?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions