feat(ban): Add ban on print statements

Author: Christian Kollross

CHANGELOG.md

@@ -5,6 +5,7 @@ master
 ------
 
 * Added rule to ban shell execution via backticks
+* Added rule to ban print statements
 
 v1.0.0
 ------

README.md

@@ -64,6 +64,11 @@ parameters:
 					- system
 					- var_dump
 
+			# enable detection of print statements
+			-
+				type: Expr_Print
+				functions: null
+
 			# enable detection of shell execution by backticks
 			-
 				type: Expr_ShellExec

extension.neon

@@ -41,6 +41,11 @@ parameters:
 					- system
 					- var_dump
 
+			# enable detection of print statements
+			-
+				type: Expr_Print
+				functions: null
+
 			# enable detection of shell execution by backticks
 			-
 				type: Expr_ShellExec

snippets/print.php

@@ -0,0 +1,3 @@
+<?php
+
+print 'test print';

snippets/print_r.php

@@ -1,3 +1,3 @@
 <?php
 
-print_r('');
+print_r('test print_r');

tests/Rules/BannedNodesRuleTest.php

@@ -20,6 +20,7 @@
 use PhpParser\Node\Expr\Exit_;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\Include_;
+use PhpParser\Node\Expr\Print_;
 use PhpParser\Node\Expr\ShellExec;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Name;
@@ -53,6 +54,7 @@ protected function setUp(): void
             ['type' => 'Expr_Eval'],
             ['type' => 'Expr_Exit'],
             ['type' => 'Expr_FuncCall', 'functions' => ['debug_backtrace', 'dump']],
+            ['type' => 'Expr_Print'],
             ['type' => 'Expr_ShellExec'],
         ]);
         $this->scope = $this->createMock(Scope::class);
@@ -136,6 +138,7 @@ public function getHandledNodes(): \Generator
     {
         yield [new Eval_($this->createMock(Expr::class))];
         yield [new Exit_()];
+        yield [new Print_($this->createMock(Expr::class))];
         yield [new ShellExec([''])];
     }
 }