Skip to content

Commit e09c956

Browse files
authored
chore: upgrade lerna and remove remaining saucelabs code (#1645)
1 parent bee7fdb commit e09c956

36 files changed

+29160
-35486
lines changed

.ci/docker/node-puppeteer/Dockerfile

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ FROM ubuntu:jammy
44
ARG NODEJS_VERSION
55

66
# Install node
7-
RUN apt-get update && apt-get install -y ca-certificates curl gnupg && \
8-
mkdir -p /etc/apt/keyrings && \
9-
curl -sL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \
10-
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODEJS_VERSION.x nodistro main" | \
11-
tee /etc/apt/sources.list.d/nodesource.list && \
12-
apt-get update && apt-get install nodejs -y && \
13-
rm -rf /etc/apt/keyrings && rm /etc/apt/sources.list.d/nodesource.list
7+
RUN apt-get update && apt-get install -y ca-certificates curl gnupg && \
8+
mkdir -p /etc/apt/keyrings && \
9+
curl -sL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \
10+
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODEJS_VERSION.x nodistro main" | \
11+
tee /etc/apt/sources.list.d/nodesource.list && \
12+
apt-get update && apt-get install nodejs -y && \
13+
rm -rf /etc/apt/keyrings && rm /etc/apt/sources.list.d/nodesource.list
1414

1515
# the node-gyp we use is only compatible with Python versions less than 3.10,
1616
# so we need to make sure we use a previous version

.ci/scripts/load-testing.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env bash
22

3-
STACK_VERSION=${1:-8.6.1}
3+
STACK_VERSION=${1:-8.19.5}
44
USER_ID="$(id -u):$(id -g)"
55
# The migration of this to Node.js 18 will wait. To update playwright (and browsers)
66
# to make it work in Node.js 18 and latest version in ubuntu (or another OS)

.ci/scripts/pull_and_build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env bash
22
export NODEJS_VERSION=$(cat .nvmrc)
3-
export STACK_VERSION=${STACK_VERSION:-8.6.1}
3+
export STACK_VERSION=${STACK_VERSION:-8.19.5}
44

55
STACK_VERSION=${STACK_VERSION} \
66
docker --log-level INFO compose -f ./dev-utils/docker-compose.yml pull --quiet --ignore-pull-failures

.ci/scripts/test.sh

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,11 @@
11
#!/usr/bin/env bash
22
set -xo pipefail
33

4-
STACK_VERSION=${STACK_VERSION:-"8.6.1"}
4+
STACK_VERSION=${STACK_VERSION:-"8.19.5"}
55
APM_SERVER_PORT=${APM_SERVER_PORT:-"8200"}
66
APM_SERVER_URL=${APM_SERVER_URL:-"http://apm-server:8200"}
77
KIBANA_URL=${KIBANA_URL:-"http://kibana:5601"}
88

9-
# As long as there are issues with the ssl lets use 6.1.3
10-
# see https://github.com/docker/docker-py/issues/3194
11-
pip3 uninstall docker
12-
pip3 install docker==6.1.3
13-
14-
pip install docker-compose>=1.25.4
15-
16-
# https://github.com/docker/docker-py/issues/3256
17-
pip3 uninstall requests
18-
pip3 install requests==2.31.0
19-
20-
219
# Tests are run within the node-puppeteer container and can fails.
2210
# To avoid flakiness, we retry up to 3 times to run them.
2311
for i in {1..3};
@@ -34,10 +22,15 @@ do
3422
--quiet-pull \
3523
--exit-code-from node-puppeteer \
3624
--remove-orphans \
37-
node-puppeteer;
25+
node-puppeteer \
26+
>docker-compose.log 2>docker-compose.err;
3827
status=${?}
3928
if [ "${status}" -eq "0" ]; then
4029
break
30+
else
31+
echo "Docker compose failed, see the below log output"
32+
cat docker-compose.log && rm docker-compose.log
33+
cat docker-compose.err && rm docker-compose.err
4134
fi
4235
sleep 5;
4336
done

.github/workflows/ci-saucelabs.yml

Lines changed: 0 additions & 85 deletions
This file was deleted.

.github/workflows/ci.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
strategy:
6666
matrix:
6767
stack-version:
68-
- '8.0.0-SNAPSHOT'
68+
- '8.2.0-SNAPSHOT'
6969
- '8.19.5'
7070
scope:
7171
- '@elastic/apm-rum'
@@ -75,6 +75,7 @@ jobs:
7575
- '@elastic/apm-rum-vue'
7676
steps:
7777
- uses: actions/checkout@v5
78+
7879
- name: Run puppeteer tests
7980
uses: ./.github/workflows/run-test
8081
with:
@@ -87,14 +88,6 @@ jobs:
8788
steps:
8889
- uses: actions/checkout@v5
8990

90-
# Temporary fix for "ValueError: invalid mode: 'rU' while trying to load binding.gyp"
91-
# See https://github.com/nodejs/node-gyp/issues/2219
92-
# This can be removed when "node-gyp" is updated
93-
- name: Set up Python 3.10
94-
uses: actions/setup-python@v6
95-
with:
96-
python-version: '3.10'
97-
9891
- uses: actions/setup-node@v5
9992
with:
10093
node-version-file: '.nvmrc'

.github/workflows/pre-release.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,6 @@ jobs:
4141
with:
4242
github-token: ${{ steps.get_token.outputs.token }}
4343

44-
# Temporary fix for "ValueError: invalid mode: 'rU' while trying to load binding.gyp"
45-
# See https://github.com/nodejs/node-gyp/issues/2219
46-
# This can be removed when "node-gyp" is updated
47-
- name: Set up Python 3.10
48-
uses: actions/setup-python@v6
49-
with:
50-
python-version: '3.10'
51-
5244
- uses: actions/setup-node@v5
5345
with:
5446
node-version-file: '.nvmrc'

.github/workflows/release.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,6 @@ jobs:
5252
with:
5353
github-token: ${{ steps.get_token.outputs.token }}
5454

55-
# Temporary fix for "ValueError: invalid mode: 'rU' while trying to load binding.gyp"
56-
# See https://github.com/nodejs/node-gyp/issues/2219
57-
# This can be removed when "node-gyp" is updated
58-
- name: Set up Python 3.10
59-
uses: actions/setup-python@v6
60-
with:
61-
python-version: '3.10'
62-
6355
- uses: actions/setup-node@v5
6456
with:
6557
node-version-file: '.nvmrc'

.github/workflows/run-test/action.yml

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,6 @@ inputs:
2020
type: choice
2121
options:
2222
- none
23-
- saucelabs
24-
sauce-username:
25-
description: 'Sauce username'
26-
required: false
27-
sauce-access-key:
28-
description: 'Sauce access key'
29-
required: false
3023

3124
runs:
3225
using: "composite"
@@ -37,17 +30,6 @@ runs:
3730
- name: Pull and build docker infra
3831
run: './.ci/scripts/pull_and_build.sh'
3932
shell: bash
40-
- if: |
41-
(inputs.mode == 'saucelabs')
42-
&& (inputs.sauce-access-key != null && inputs.sauce-access-key != '')
43-
&& (inputs.sauce-username != null && inputs.sauce-username != '')
44-
shell: bash
45-
run: |
46-
echo "SAUCE_ACCESS_KEY=$SAUCE_ACCESS_KEY" >> $GITHUB_ENV
47-
echo "SAUCE_USERNAME=$SAUCE_USERNAME" >> $GITHUB_ENV
48-
env:
49-
SAUCE_ACCESS_KEY: ${{ inputs.sauce-access-key }}
50-
SAUCE_USERNAME: ${{ inputs.sauce-username }}
5133
- name: Run tests Elastic Stack ${{ matrix.stack-version }} - ${{ matrix.scope }} - ${{ fromJSON('{"none":"Puppeteer"}')[inputs.mode] || inputs.mode }}
5234
run: './.ci/scripts/test.sh'
5335
shell: bash
@@ -70,9 +52,3 @@ runs:
7052
name: test-results-${{ steps.slug.outputs.slug }}
7153
path: |
7254
packages/**/reports/TESTS-*.xml
73-
- name: Reset environment
74-
if: always()
75-
shell: bash
76-
run: |
77-
echo "SAUCE_ACCESS_KEY=" >> $GITHUB_ENV
78-
echo "SAUCE_USERNAME=" >> $GITHUB_ENV

.github/workflows/test-reporter.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ on:
55
workflow_run:
66
workflows:
77
- ci
8-
- ci-saucelabs
98
types:
109
- completed
1110

0 commit comments

Comments
 (0)