Support sort in ExtendedSearchUsage

[pquentin]

Added by @davidkyle in elastic/elasticsearch#139530. I initially wanted to do this instead:

export enum SortType {
  _doc,
  _geo_distance,
  _score,
  _script,
  field_sort,
}

sort?: Dictionary<SortType, long>

However, typescript-generator converts that to a Record which expects all keys to be present:

elasticsearch-specification/typescript-generator/src/index.ts

Lines 129 to 132 in 696f1cd

	case 'dictionary_of': {
	const result = `Record<${buildValue(type.key, openGenerics)}, ${buildValue(type.value, openGenerics)}>`
	return type.singleKey ? `Partial<${result}>` : result
	}

Interestingly, SingleKeyDictionary uses Partial which makes validation pass, but that's wrong. Since search usage is highly dynamic instead, I've opted for string.

[github-actions]

Following you can find the validation changes against the target branch for the API.

API	Status	Request	Response
cluster.stats	🔴 → 🟢	27/27	0/27 → 27/27

You can validate this API yourself by using the make validate target.

[davidkyle]

LGTM

Thanks @pquentin I didn't think to update the spec for my change

[flobernd]

However, typescript-generator converts that to a Record which expects all keys to be present:

Mhh, I wonder if this is intended and if we should really prefer string vs. a proper enum just because of that technical constraint?