-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Option to remove key_as_string from aggregation response #63898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
I'm a first time contributor to this project and would like to take on this issue |
Just an idea: would it make sense to implement this based on the human flag that every API already supports? |
I think that'd be breaking change. Its a good idea though! It looks like we always have a guard for emitting these like |
I see, because the human flag has a global default which is |
Hi @wylieconlon @javanna , |
@akshataj96 & @alishahusain - As we looked deeper into this as a team, we found more complexity than we initially thought, and we've decided we need to address this internally. Sorry that we were a little too optimistic in labeling it |
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Formatted keys are not always needed when the original value is used by client code, but are always returned. If there were an option to remove the formatted values then we could reduce the total response size of ES queries by going from this type of response:
to this:
One option that would be nice would be to have a parameter called
"include_formatted": false
on the date histogram and other aggregations that return formatted keys.There are existing workarounds, but both workarounds have issues:
format
to a special character like_
will reduce some of the response size, but the response will still contain"key_as_string": "_"
instead of being removed.cc @polyfractal
The text was updated successfully, but these errors were encountered: