Skip to content

Conversation

@3kt
Copy link
Contributor

@3kt 3kt commented Nov 12, 2025

Proposed commit message

This adds a toggle button on the billing integration allowing the collection of deployment tags, which are then added to each billing object related to the corresponding deployment. In case the toggle isn't activated, the old behavior is kept identical

Considerations

There are some caveats:

  1. As the commercial cloud URL is hardcoded, this is only functional for commercial cloud and not gov cloud. This also prevents the override to admin.
  2. The tags are stored as a list of key:value strings, rather than nested objects to prevent mapping explosion.
  3. This doesn't consider historical tags. In other words, the deployment receive the tags that they have at the moment of the data pull, rather than at the time the billing occurred.
  4. This doesn't work for serverless projects.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Validate that the caveats are accepted
  • Evaluate whether we want to extend dashboards
  • Evaluate whether we want to make the tag pull behavior default, and remove the control of the user over the setting altogether.

How to test this PR locally

  1. Spin a local environment with elastic-package stack up -v -d
  2. Set some relevant tags on the deployment of your choice
  3. Collect the organization ID and billing API key for your organization.
  4. Deploy the integration while activating the Add deployment tags toggle.

Related issues

None

Screenshots

image

@3kt 3kt added enhancement New feature or request Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Integration:ess_billing Elasticsearch Service Billing labels Nov 12, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:ess_billing Elasticsearch Service Billing Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants