Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove v1 of PQ page implementation #16670

Open
yaauie opened this issue Nov 12, 2024 · 0 comments
Open

TASK: Remove v1 of PQ page implementation #16670

yaauie opened this issue Nov 12, 2024 · 0 comments

Comments

@yaauie
Copy link
Member

yaauie commented Nov 12, 2024

Starting with Logstash 6.3.0 (June 2018), pipelines using queue.type: persisted have written and processed events using a "V2" implementation. When a pipeline is started and a non-empty "V1" PQ is observed on disk, the V1 PQ page files are upgraded in place before the pipeline can complete starting up.

Since we have no reasonable expectation for Logstash 9.x to load PQ page files that were left behind by Logstash < 6.3.0, we can safely remove the V1 implementation and the queue version upgrade code, simplifying the footprint of maintaining and evolving the PQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant