fix: cscIKeyPassword must support empty string arguments (#8653)

IsaacAderogba · web-flow · commit 796e1a072a2b · 2024-11-01T09:36:17.000-07:00
diff --git a/.changeset/fresh-camels-smash.md b/.changeset/fresh-camels-smash.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix: cscIKeyPassword must support empty string arguments
diff --git a/packages/app-builder-lib/src/codeSign/macCodeSign.ts b/packages/app-builder-lib/src/codeSign/macCodeSign.ts
@@ -198,7 +198,7 @@ export async function createKeychain({ tmpDir, cscLink, cscKeyPassword, cscILink
     BluebirdPromise.mapSeries(securityCommands, it => exec("/usr/bin/security", it)),
   ])
   const cscPasswords: Array<string> = [cscKeyPassword]
-  if (cscIKeyPassword) {
+  if (cscIKeyPassword != null) {
     cscPasswords.push(cscIKeyPassword)
   }
   return await importCerts(keychainFile, certPaths, cscPasswords)

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ export async function createKeychain({ tmpDir, cscLink, cscKeyPassword, cscILink`
`198`	`198`	`BluebirdPromise.mapSeries(securityCommands, it => exec("/usr/bin/security", it)),`
`199`	`199`	`])`
`200`	`200`	`const cscPasswords: Array<string> = [cscKeyPassword]`
`201`		`- if (cscIKeyPassword) {`
	`201`	`+ if (cscIKeyPassword != null) {`
`202`	`202`	`cscPasswords.push(cscIKeyPassword)`
`203`	`203`	`}`
`204`	`204`	`return await importCerts(keychainFile, certPaths, cscPasswords)`