Skip to content

Commit cc8c70f

Browse files
authored
fix: add CodeSigningAccountName as required prop in Azure Signing Options (#8533)
Ref: #8276 (comment)
1 parent eaf274d commit cc8c70f

File tree

5 files changed

+17
-1
lines changed

5 files changed

+17
-1
lines changed

.changeset/real-otters-sparkle.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"app-builder-lib": patch
3+
---
4+
5+
fix: add `CodeSigningAccountName` as required prop in Azure Signing Options

packages/app-builder-lib/scheme.json

+5
Original file line numberDiff line numberDiff line change
@@ -5977,13 +5977,18 @@
59775977
"description": "The Certificate Profile name. Translates to field: CertificateProfileName",
59785978
"type": "string"
59795979
},
5980+
"codeSigningAccountName": {
5981+
"description": "The Code Signing Signing Account name. Translates to field: CodeSigningAccountName",
5982+
"type": "string"
5983+
},
59805984
"endpoint": {
59815985
"description": "The Trusted Signing Account endpoint. The URI value must have a URI that aligns to the\nregion your Trusted Signing Account and Certificate Profile you are specifying were created\nin during the setup of these resources.\n\nTranslates to field: Endpoint\n\nRequires one of environment variable configurations for authenticating to Microsoft Entra ID per [Microsoft's documentation](https://learn.microsoft.com/en-us/dotnet/api/azure.identity.environmentcredential?view=azure-dotnet#definition)",
59825986
"type": "string"
59835987
}
59845988
},
59855989
"required": [
59865990
"certificateProfileName",
5991+
"codeSigningAccountName",
59875992
"endpoint"
59885993
],
59895994
"type": "object"

packages/app-builder-lib/src/codeSign/windowsSignAzureManager.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,13 @@ export class WindowsSignAzureManager {
7979
const vm = await this.packager.vm.value
8080
const ps = await getPSCmd(vm)
8181

82-
const { endpoint, certificateProfileName, ...extraSigningArgs }: WindowsAzureSigningConfiguration = options.options.azureSignOptions!
82+
const { endpoint, certificateProfileName, codeSigningAccountName, ...extraSigningArgs }: WindowsAzureSigningConfiguration = options.options.azureSignOptions!
8383
const params = {
8484
FileDigest: "SHA256",
8585
...extraSigningArgs, // allows overriding FileDigest if provided in config
8686
Endpoint: endpoint,
8787
CertificateProfileName: certificateProfileName,
88+
CodeSigningAccountName: codeSigningAccountName,
8889
Files: options.path,
8990
}
9091
const paramsString = Object.entries(params)

packages/app-builder-lib/src/options/winOptions.ts

+4
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,10 @@ export interface WindowsAzureSigningConfiguration {
203203
* The Certificate Profile name. Translates to field: CertificateProfileName
204204
*/
205205
readonly certificateProfileName: string
206+
/**
207+
* The Code Signing Signing Account name. Translates to field: CodeSigningAccountName
208+
*/
209+
readonly codeSigningAccountName: string
206210
/**
207211
* Allow other CLI parameters (verbatim case-sensitive) to `Invoke-TrustedSigning`
208212
*/

test/src/windows/winCodeSignTest.ts

+1
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ test.ifAll.ifNotCiMac(
123123
azureSignOptions: {
124124
endpoint: "https://weu.codesigning.azure.net/",
125125
certificateProfileName: "profilenamehere",
126+
codeSigningAccountName: "codesigningnamehere"
126127
},
127128
},
128129
},

0 commit comments

Comments
 (0)