Skip to content

Fix support for snapcraft core22 and core24 #8548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
filfreire opened this issue Sep 30, 2024 · 4 comments
Open

Fix support for snapcraft core22 and core24 #8548

filfreire opened this issue Sep 30, 2024 · 4 comments

Comments

@filfreire
Copy link
Contributor

As of now it's possible to build for core22 but it uses the wrong plugs. The latest core24 is not properly supported.

Adding proper support for both would require different plugs setup on the snapcraft.yaml as well as likely workarounds depending on version, e.g. different extensions.

See https://snapcraft.io/docs/gnome-3-34-extension and https://snapcraft.io/docs/gnome-extension

Side-note: Currently, the default plugs are also not the proper ones if we account for using Ubuntu 20 as base (core20), So it's also probably worth to look into it. Related to #6976 (comment)

I'm preparing a PR to attempt to tackle this issue.

Similar PRs: #7320 , #7378
@filfreire filfreire mentioned this issue Sep 30, 2024
Closed
@furgo16 furgo16 mentioned this issue Oct 4, 2024
Closed
@SomeAspy SomeAspy mentioned this issue Oct 15, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 2, 2025
@esimkowitz
Copy link

this is still valid

@github-actions github-actions bot removed the Stale label Mar 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Apr 3, 2025
@ollm
Copy link

ollm commented Apr 5, 2025

It is still valid

@github-actions github-actions bot removed the Stale label Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: snapcraft core22 and core24 support [#8548] filfreire/electron-builder
3 participants
@filfreire @esimkowitz @ollm