Skip to content

feat: Check for Silent Flag in NSIS Uninstaller #9282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 14, 2025
Merged

feat: Check for Silent Flag in NSIS Uninstaller #9282

merged 9 commits into from
Nov 14, 2025

Conversation

@naderhen
Copy link
Contributor

@naderhen naderhen commented Sep 23, 2025

Currently, there is no way to suppress the "Are you sure you want to uninstall?" dialog when running the uninstaller exe with the \S. It doesn't appear that there are any hooks that would allow me to check for this on my own, so I'm hoping this helps.

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 2d95288

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@naderhen naderhen changed the title NSIS: Check for Silent Flag in Uninstaller feat: Check for Silent Flag in NSIS Uninstaller Sep 23, 2025
@naderhen naderhen mentioned this pull request Sep 23, 2025
Closed
@mmaietta
Copy link
Collaborator

mmaietta commented Sep 29, 2025

FYI, this LGTM, but I need to fix the core test-updater test suite before I can merge this. Working on this currently and hope to resolve asap

@mmaietta mmaietta linked an issue Sep 29, 2025 that may be closed by this pull request
NSIS Uninstaller: Respect Silent Flag #9283
Closed
@naderhen
Copy link
Contributor Author

naderhen commented Sep 29, 2025

thanks @mmaietta ! Will keep an eye out for when this goes in

mmaietta
mmaietta reviewed Nov 11, 2025
View reviewed changes
@naderhen naderhen requested a review from mmaietta November 11, 2025 17:38
@naderhen
Copy link
Contributor Author

naderhen commented Nov 11, 2025

@mmaietta apologies for the re-request, github said I needed a new approval after updating the branch against main

@mmaietta mmaietta merged commit 836a15c into electron-userland:master Nov 14, 2025
41 of 42 checks passed
@electron-builder-release-bot electron-builder-release-bot bot mentioned this pull request Nov 14, 2025
Merged
mmaietta pushed a commit that referenced this pull request Nov 15, 2025
@electron-builder-release-bot
chore(deploy): Release v26.2.0 ([email protected]) (#9345)
f0aaabf 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to master, this PR
will be updated.


# Releases
## [email protected]

### Minor Changes

-
[#9333](#9333)
[`6a49f85c69a22844729033f023249975f47a28f1`](6a49f85)
Thanks [@chroberino](https://github.com/chroberino)! - feat: Allow local
nsis-resources via env var `ELECTRON_BUILDER_NSIS_RESOURCES_DIR`

-
[#9279](#9279)
[`b6a34c00c35e42dc279a55d672558ea7badc7fcd`](b6a34c0)
Thanks [@iamEvanYT](https://github.com/iamEvanYT)! - feat: support Icon
Composer icons for macOS

### Patch Changes

-
[#9282](#9282)
[`836a15c6c70abf8582aaa63603e14f77d5fa3f89`](836a15c)
Thanks [@naderhen](https://github.com/naderhen)! - NSIS: Fix
non-utilized for Silent Flag in Uninstaller

-
[#9334](#9334)
[`21623e1b037e4509af04e767ca1c1458682b0eba`](21623e1)
Thanks [@mmaietta](https://github.com/mmaietta)! - chore: remove "beta"
labels from a few features

-
[#9300](#9300)
[`0835fbcac0a0cfb0f34355699812cc85db035ad4`](0835fbc)
Thanks [@mmaietta](https://github.com/mmaietta)! - chore: updating pnpm
and setting minimumReleaseAge to 1 week

-
[#9346](#9346)
[`d19387174365c85968034149be43d80a39e7335f`](d193871)
Thanks [@mmaietta](https://github.com/mmaietta)! - fix: revert PR
<#9068> due to
breaking change

-
[#9337](#9337)
[`f4d7924a082fbb9113d52782430f82b1f0ffcb52`](f4d7924)
Thanks [@mmaietta](https://github.com/mmaietta)! - fix: change default
value of disable_wayland depending on electron version (in order to
support elevtron >38)

-   Updated dependencies \[]:
    -   [email protected]
    -   [email protected]

## [email protected]

### Patch Changes

- Updated dependencies
\[[`836a15c6c70abf8582aaa63603e14f77d5fa3f89`](836a15c),
[`21623e1b037e4509af04e767ca1c1458682b0eba`](21623e1),
[`6a49f85c69a22844729033f023249975f47a28f1`](6a49f85),
[`0835fbcac0a0cfb0f34355699812cc85db035ad4`](0835fbc),
[`d19387174365c85968034149be43d80a39e7335f`](d193871),
[`b6a34c00c35e42dc279a55d672558ea7badc7fcd`](b6a34c0),
[`f4d7924a082fbb9113d52782430f82b1f0ffcb52`](f4d7924)]:
    -   [email protected]

## [email protected]

### Patch Changes

- Updated dependencies
\[[`836a15c6c70abf8582aaa63603e14f77d5fa3f89`](836a15c),
[`21623e1b037e4509af04e767ca1c1458682b0eba`](21623e1),
[`6a49f85c69a22844729033f023249975f47a28f1`](6a49f85),
[`0835fbcac0a0cfb0f34355699812cc85db035ad4`](0835fbc),
[`d19387174365c85968034149be43d80a39e7335f`](d193871),
[`b6a34c00c35e42dc279a55d672558ea7badc7fcd`](b6a34c0),
[`f4d7924a082fbb9113d52782430f82b1f0ffcb52`](f4d7924)]:
    -   [email protected]
    -   [email protected]

## [email protected]

### Patch Changes

- Updated dependencies
\[[`836a15c6c70abf8582aaa63603e14f77d5fa3f89`](836a15c),
[`21623e1b037e4509af04e767ca1c1458682b0eba`](21623e1),
[`6a49f85c69a22844729033f023249975f47a28f1`](6a49f85),
[`0835fbcac0a0cfb0f34355699812cc85db035ad4`](0835fbc),
[`d19387174365c85968034149be43d80a39e7335f`](d193871),
[`b6a34c00c35e42dc279a55d672558ea7badc7fcd`](b6a34c0),
[`f4d7924a082fbb9113d52782430f82b1f0ffcb52`](f4d7924)]:
    -   [email protected]

## [email protected]

### Patch Changes

- Updated dependencies
\[[`836a15c6c70abf8582aaa63603e14f77d5fa3f89`](836a15c),
[`21623e1b037e4509af04e767ca1c1458682b0eba`](21623e1),
[`6a49f85c69a22844729033f023249975f47a28f1`](6a49f85),
[`0835fbcac0a0cfb0f34355699812cc85db035ad4`](0835fbc),
[`d19387174365c85968034149be43d80a39e7335f`](d193871),
[`b6a34c00c35e42dc279a55d672558ea7badc7fcd`](b6a34c0),
[`f4d7924a082fbb9113d52782430f82b1f0ffcb52`](f4d7924)]:
    -   [email protected]

## [email protected]

### Patch Changes

- Updated dependencies
\[[`836a15c6c70abf8582aaa63603e14f77d5fa3f89`](836a15c),
[`21623e1b037e4509af04e767ca1c1458682b0eba`](21623e1),
[`6a49f85c69a22844729033f023249975f47a28f1`](6a49f85),
[`0835fbcac0a0cfb0f34355699812cc85db035ad4`](0835fbc),
[`d19387174365c85968034149be43d80a39e7335f`](d193871),
[`b6a34c00c35e42dc279a55d672558ea7badc7fcd`](b6a34c0),
[`f4d7924a082fbb9113d52782430f82b1f0ffcb52`](f4d7924)]:
    -   [email protected]

## [email protected]

### Patch Changes

- Updated dependencies
\[[`836a15c6c70abf8582aaa63603e14f77d5fa3f89`](836a15c),
[`21623e1b037e4509af04e767ca1c1458682b0eba`](21623e1),
[`6a49f85c69a22844729033f023249975f47a28f1`](6a49f85),
[`0835fbcac0a0cfb0f34355699812cc85db035ad4`](0835fbc),
[`d19387174365c85968034149be43d80a39e7335f`](d193871),
[`b6a34c00c35e42dc279a55d672558ea7badc7fcd`](b6a34c0),
[`f4d7924a082fbb9113d52782430f82b1f0ffcb52`](f4d7924)]:
    -   [email protected]

## [email protected]

### Patch Changes

- Updated dependencies
\[[`836a15c6c70abf8582aaa63603e14f77d5fa3f89`](836a15c),
[`21623e1b037e4509af04e767ca1c1458682b0eba`](21623e1),
[`6a49f85c69a22844729033f023249975f47a28f1`](6a49f85),
[`0835fbcac0a0cfb0f34355699812cc85db035ad4`](0835fbc),
[`d19387174365c85968034149be43d80a39e7335f`](d193871),
[`b6a34c00c35e42dc279a55d672558ea7badc7fcd`](b6a34c0),
[`f4d7924a082fbb9113d52782430f82b1f0ffcb52`](f4d7924)]:
    -   [email protected]

## [email protected]

### Patch Changes

-
[#9334](#9334)
[`21623e1b037e4509af04e767ca1c1458682b0eba`](21623e1)
Thanks [@mmaietta](https://github.com/mmaietta)! - chore: remove "beta"
labels from a few features

Co-authored-by: electron-builder-release-bot[bot] <236325277+electron-builder-release-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmaietta mmaietta mmaietta approved these changes

Assignees

No one assigned

Labels

app-builder-lib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NSIS Uninstaller: Respect Silent Flag

2 participants

@naderhen @mmaietta