Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktopCapturer crashing on linux w/XDP when the capture portal is dismissed/closed #45198

Open
3 tasks done
Covkie opened this issue Jan 14, 2025 · 5 comments · May be fixed by #46112
Open
3 tasks done

desktopCapturer crashing on linux w/XDP when the capture portal is dismissed/closed #45198

Covkie opened this issue Jan 14, 2025 · 5 comments · May be fixed by #46112

Comments

@Covkie
Copy link

Covkie commented Jan 14, 2025

Preflight Checklist

Electron Version

32.0.0, 33.0.0, 34.0.0

What operating system(s) are you using?

Other Linux

Operating System Version

Linux bakery 6.12.9-zen1-1-zen #1 ZEN SMP PREEMPT_DYNAMIC Fri, 10 Jan 2025 00:39:35 +0000 x86_64 GNU/Linux

What arch are you using?

x64

Last Known Working Electron version

31.3.1 - No crashing but cannot open another portal request. 31.4.0 & later crashes

Expected Behavior

Doesn't crash & allows following requests

Actual Behavior

When the user closes the portal picker electron will crash.

Testcase Gist URL

https://www.electronjs.org/docs/latest/api/desktop-capturer the example provided is a simple repro

Additional Information

When attempting this from chromium the same errors will be spit out but there is no crash and can make following pick attempts so I believe theyre unrelated. Other than that theres no logs.

[10356:10356:0114/163419.616405:ERROR:screencast_portal.cc(367)] Failed to start the screen cast session.
[10356:10356:0114/163419.616432:ERROR:base_capturer_pipewire.cc(81)] ScreenCastPortal failed: 2
@github-project-automation github-project-automation bot moved this to 👀 Unsorted Items in 33-x-y Jan 14, 2025
@github-project-automation github-project-automation bot moved this to 👀 Unsorted Items in 34-x-y Jan 14, 2025
@Covkie Covkie changed the title desktopCapturer crashing on linux w/XDG when the capture portal is dismissed/closed desktopCapturer crashing on linux w/XDP when the capture portal is dismissed/closed Jan 15, 2025
@VerteDinde VerteDinde added the blocked/need-repro Needs a test case to reproduce the bug label Jan 15, 2025
@VerteDinde VerteDinde moved this from 👀 Unsorted Items to 👍 Does Not Block Stable in 33-x-y Jan 15, 2025
@VerteDinde VerteDinde moved this from 👀 Unsorted Items to 👍 Does Not Block Stable in 34-x-y Jan 15, 2025
@electron-issue-triage
Copy link

Hello @Covkie. Thanks for reporting this and helping to make Electron better!

Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.

Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

Now adding the blocked/need-repro Needs a test case to reproduce the bug label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed.

@Covkie
Copy link
Author

Covkie commented Jan 16, 2025

https://gist.github.com/7335c2f02a56b67e19c0941491e5e6a3

Here's the example on the docs in gist form

@electron-issue-triage electron-issue-triage bot removed the blocked/need-repro Needs a test case to reproduce the bug label Jan 16, 2025
@103sbavert
Copy link

Commenting to confirm that this happens on Flatpak apps using Electron as well.

@codebytere
Copy link
Member

Could you please attach a crash dump to help us get more information? You can collect them by adding the following snippet to your main process code, before app.whenReady:

const { app, crashReporter } = require('electron')
console.log(app.getPath('crashDumps'))
crashReporter.start({ submitURL: '', uploadToServer: false })

Then reproduce the crash, zip up the crash dumps directory and attach it here. Thanks!

@codebytere codebytere added the blocked/need-info ❌ Cannot proceed without more information label Jan 22, 2025
@Covkie
Copy link
Author

Covkie commented Jan 23, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 👍 Does Not Block Stable
Status: 👍 Does Not Block Stable
Development

Successfully merging a pull request may close this issue.

5 participants