Error: path quoting issue on Windows #1199
Description
When upgrading from
@electron/rebuild
devDependencies
major
^3.7.2 -> ^4.0.1
electron
dependencies
major
35.5.1 -> 37.2.1
our builds start failing with what looks like a path quoting issue:
[5/5] Building fresh packages...
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
error C:\b\10759944477\node_modules\pprof: Command failed.
Exit code: 1
Command: node-pre-gyp install --fallback-to-build
Arguments:
Directory: C:\b\10759944477\node_modules\pprof
Output:
[info] it worked if it ends with ok
[info] using [email protected]
[info] using [email protected] | win32 | x64
[info] check checked for "C:\b\10759944477\node_modules\pprof\build\node-v127-win32-x64-unknown\pprof.node" (not found)
[log] GET https://storage.googleapis.com/cloud-profiler/pprof-nodejs/release/v4.0.0/node-v127-win32-x64-unknown.tar.gz
[error] install response status 404 Not Found on https://storage.googleapis.com/cloud-profiler/pprof-nodejs/release/v4.0.0/node-v127-win32-x64-unknown.tar.gz
[warn] Pre-built binaries not installable for [email protected] and [email protected] (node-v127 ABI, unknown) (falling back to source compile with node-gyp)
[warn] Hit error response status 404 Not Found on https://storage.googleapis.com/cloud-profiler/pprof-nodejs/release/v4.0.0/node-v127-win32-x64-unknown.tar.gz
'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
[error] build error
[error] stack Error: Failed to execute 'C:\Program Files\nodejs\node.exe C:\b\10759944477\node_modules\node-gyp\bin\node-gyp.js clean' (1)