From 1d08edd7bfc0e88260c0d8135e4a4767b06c8ad7 Mon Sep 17 00:00:00 2001 From: Hugh Nimmo-Smith Date: Wed, 18 Dec 2024 13:48:29 +0000 Subject: [PATCH 1/2] Inject sentry release information at runtime not build time See https://github.com/element-hq/element-call/issues/2871 for context of impact. --- src/initializer.tsx | 1 + vite.config.ts | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/src/initializer.tsx b/src/initializer.tsx index e92905045..5cf081a97 100644 --- a/src/initializer.tsx +++ b/src/initializer.tsx @@ -220,6 +220,7 @@ export class Initializer { Sentry.reactRouterV5BrowserTracingIntegration({ history }), ], tracesSampleRate: 1.0, + release: process.env.VITE_APP_VERSION, }); } // Sentry is now 'loadeed' (even if we actually skipped starting diff --git a/vite.config.ts b/vite.config.ts index e38f6a309..7414a3f8e 100644 --- a/vite.config.ts +++ b/vite.config.ts @@ -56,6 +56,10 @@ export default defineConfig(({ mode }) => { sentryVitePlugin({ release: { name: process.env.VITE_APP_VERSION, + // We don't inject the release info at build time because it has a side effect of + // changing the asset hashes each time meaning that it breaks browser caching. + // Instead we pass it in at runtime via Sentry.init(). + inject: false, }, }), ); From c4b9824d4cb51396cd57455e35016629c97d911c Mon Sep 17 00:00:00 2001 From: Hugh Nimmo-Smith Date: Wed, 18 Dec 2024 13:59:23 +0000 Subject: [PATCH 2/2] . --- src/initializer.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/initializer.tsx b/src/initializer.tsx index 5cf081a97..3295cc733 100644 --- a/src/initializer.tsx +++ b/src/initializer.tsx @@ -220,7 +220,7 @@ export class Initializer { Sentry.reactRouterV5BrowserTracingIntegration({ history }), ], tracesSampleRate: 1.0, - release: process.env.VITE_APP_VERSION, + release: import.meta.env.VITE_APP_VERSION, }); } // Sentry is now 'loadeed' (even if we actually skipped starting