Iterate

Signed-off-by: Michael Telatynski <[email protected]>

Author: t3chguy

.lintstagedrc

@@ -1,4 +1,3 @@
 {
-    "*": "prettier --write",
-    "*.(ts|tsx)": ["eslint --fix"]
+    "*": ["biome check --no-errors-on-unmatched --files-ignore-unknown=true"]
 }

biome.jsonc

@@ -1,5 +1,14 @@
 {
     "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+    "vcs": {
+        "enabled": true,
+        "clientKind": "git",
+        "useIgnoreFile": true
+    },
+    "files": {
+        "ignoreUnknown": false,
+        "ignore": []
+    },
     "formatter": {
         "enabled": true,
         "useEditorconfig": true,
@@ -9,43 +18,17 @@
         "lineEnding": "lf",
         "lineWidth": 120,
         "attributePosition": "auto",
-        "bracketSpacing": true,
-        "ignore": [
-            "../element-web",
-            "./build/",
-            "./docker/",
-            "./dist/**",
-            "./.hak/**",
-            "./dockerbuild/",
-            "./lib/",
-            "./node_modules/",
-            "./packages.elememt.io/",
-            "./webapp",
-            "./src/i18n/strings",
-            "./CHANGELOG.md",
-            "./package-lock.json",
-            "./yarn.lock",
-            "./playwright/html-report",
-            "./playwright/test-results",
-            "**/.idea",
-            "**/.vscode",
-            "**/.vscode/",
-            "**/.tmp",
-            "**/.env",
-            "./coverage",
-            "./.npmrc",
-            "./*.log"
-        ]
+        "bracketSpacing": true
     },
-    "organizeImports": { "enabled": false },
+    "organizeImports": { "enabled": true },
     "linter": {
-        "enabled": false,
+        "enabled": true,
         "rules": {
             "recommended": false,
             "complexity": {
                 "noExtraBooleanCast": "error",
                 "noMultipleSpacesInRegularExpressionLiterals": "error",
-                "noUselessCatch": "off",
+                "noUselessCatch": "error",
                 "noWith": "error"
             },
             "correctness": {
@@ -77,16 +60,18 @@
             "style": {
                 "noArguments": "error",
                 "noVar": "error",
-                "useBlockStatements": "error",
+                "useBlockStatements": "off",
                 "useConsistentBuiltinInstantiation": "error",
                 "useConst": "error",
                 "useNodejsImportProtocol": "error",
                 "useSingleVarDeclarator": "error",
-                "useThrowOnlyError": "error"
+                "useThrowOnlyError": "error",
+                "useImportType": "error",
+                "useExportType": "error"
             },
             "suspicious": {
                 "noAssignInExpressions": "error",
-                "noAsyncPromiseExecutor": "off",
+                "noAsyncPromiseExecutor": "error",
                 "noCatchAssign": "error",
                 "noClassAssign": "error",
                 "noCompareNegZero": "error",
@@ -103,7 +88,7 @@
                 "noGlobalAssign": "error",
                 "noImportAssign": "error",
                 "noMisleadingCharacterClass": "error",
-                "noPrototypeBuiltins": "off",
+                "noPrototypeBuiltins": "error",
                 "noRedeclare": "error",
                 "noShadowRestrictedNames": "error",
                 "noSparseArray": "error",
@@ -129,25 +114,7 @@
     },
     "overrides": [
         {
-            "include": ["src/**/*.ts"],
-            "linter": {
-                "rules": {
-                    "style": { "noNonNullAssertion": "off" },
-                    "suspicious": { "noExplicitAny": "off" }
-                }
-            }
-        },
-        {
-            "include": ["hak/**/*.ts"],
-            "linter": {
-                "rules": {
-                    "style": { "noNonNullAssertion": "off" },
-                    "suspicious": { "noExplicitAny": "off" }
-                }
-            }
-        },
-        {
-            "include": ["scripts/**/*.ts"],
+            "include": ["src/**/*.ts", "hak/**/*.ts", "scripts/**/*.ts", "playwright/**/*.ts"],
             "linter": {
                 "rules": {
                     "style": { "noNonNullAssertion": "off" },
@@ -159,44 +126,9 @@
             "include": ["playwright/**/*.ts"],
             "linter": {
                 "rules": {
-                    "style": { "noNonNullAssertion": "off" },
-                    "suspicious": { "noExplicitAny": "off" }
-                }
-            }
-        },
-        {
-            "include": ["src/**/*.ts"],
-            "linter": {
-                "rules": {
-                    "style": { "noNonNullAssertion": "off" },
-                    "suspicious": { "noExplicitAny": "off" }
-                }
-            }
-        },
-        {
-            "include": ["hak/**/*.ts"],
-            "linter": {
-                "rules": {
-                    "style": { "noNonNullAssertion": "off" },
-                    "suspicious": { "noExplicitAny": "off" }
-                }
-            }
-        },
-        {
-            "include": ["scripts/**/*.ts"],
-            "linter": {
-                "rules": {
-                    "style": { "noNonNullAssertion": "off" },
-                    "suspicious": { "noExplicitAny": "off" }
-                }
-            }
-        },
-        {
-            "include": ["playwright/**/*.ts"],
-            "linter": {
-                "rules": {
-                    "style": { "noNonNullAssertion": "off" },
-                    "suspicious": { "noExplicitAny": "off" }
+                    "correctness": {
+                        "noEmptyPattern": "off"
+                    }
                 }
             }
         }

electron-builder.ts

@@ -1,10 +1,10 @@
-import * as os from "node:os";
 import * as fs from "node:fs";
+import { readFile, writeFile } from "node:fs/promises";
+import * as os from "node:os";
 import * as path from "node:path";
-import * as plist from "plist";
-import { AfterPackContext, Arch, Configuration as BaseConfiguration, Platform } from "electron-builder";
 import { computeData } from "app-builder-lib/out/asar/integrity";
-import { readFile, writeFile } from "node:fs/promises";
+import { type AfterPackContext, Arch, type Configuration as BaseConfiguration, Platform } from "electron-builder";
+import * as plist from "plist";
 
 /**
  * This script has different outputs depending on your os platform.

hak/matrix-seshat/build.ts

@@ -6,8 +6,8 @@ SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Com
 Please see LICENSE files in the repository root for full details.
 */
 
-import type HakEnv from "../../scripts/hak/hakEnv.js";
 import type { DependencyInfo } from "../../scripts/hak/dep.js";
+import type HakEnv from "../../scripts/hak/hakEnv.js";
 
 export default async function (hakEnv: HakEnv, moduleInfo: DependencyInfo): Promise<void> {
     const env = hakEnv.makeGypEnv();

hak/matrix-seshat/check.ts

@@ -9,9 +9,9 @@ Please see LICENSE files in the repository root for full details.
 import childProcess from "node:child_process";
 import fsProm from "node:fs/promises";
 
+import type { DependencyInfo } from "../../scripts/hak/dep.js";
 import type HakEnv from "../../scripts/hak/hakEnv.js";
 import type { Tool } from "../../scripts/hak/hakEnv.js";
-import type { DependencyInfo } from "../../scripts/hak/dep.js";
 
 export default async function (hakEnv: HakEnv, _moduleInfo: DependencyInfo): Promise<void> {
     const tools: Tool[] = [

knip.ts

@@ -1,4 +1,4 @@
-import { KnipConfig } from "knip";
+import type { KnipConfig } from "knip";
 
 export default {
     entry: ["src/electron-main.ts", "src/preload.ts", "electron-builder.ts", ".eslintrc-*.js", "scripts/**", "hak/**"],

package.json

@@ -27,8 +27,8 @@
         "asar-webapp": "asar p webapp webapp.asar",
         "start": "yarn run build:ts && yarn run build:res && electron .",
         "lint": "yarn lint:types && yarn lint:js && yarn lint:workflows",
-        "lint:js": "biome lint",
-        "lint:js-fix": "biome lint --write",
+        "lint:js": "biome check",
+        "lint:js-fix": "biome check --write",
         "lint:types": "yarn lint:types:src && yarn lint:types:test && yarn lint:types:scripts && yarn lint:types:hak",
         "lint:types:src": "tsc --noEmit",
         "lint:types:test": "tsc --noEmit -p playwright/tsconfig.json",
@@ -95,7 +95,6 @@
         "lint-staged": "^15.2.10",
         "matrix-web-i18n": "^3.2.1",
         "mkdirp": "^3.0.0",
-        "oxlint": "^0.16.0",
         "pacote": "^21.0.0",
         "plist": "^3.1.0",
         "rimraf": "^6.0.0",

playwright/e2e/launch/config-options.spec.ts

@@ -5,10 +5,10 @@ SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Com
 Please see LICENSE files in the repository root for full details.
 */
 
-import { resolve, dirname } from "node:path";
+import { dirname, resolve } from "node:path";
 import { fileURLToPath } from "node:url";
 
-import { test, expect } from "../../element-desktop-test.js";
+import { expect, test } from "../../element-desktop-test.js";
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
 

playwright/e2e/launch/launch.spec.ts

@@ -8,7 +8,7 @@ Please see LICENSE files in the repository root for full details.
 
 import { platform } from "node:os";
 
-import { test, expect } from "../../element-desktop-test.js";
+import { expect, test } from "../../element-desktop-test.js";
 
 declare global {
     interface Window {

playwright/element-desktop-test.ts

@@ -6,12 +6,12 @@ SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Com
 Please see LICENSE files in the repository root for full details.
 */
 
-import { _electron as electron, test as base, expect as baseExpect, type ElectronApplication } from "@playwright/test";
 import fs from "node:fs/promises";
-import path, { dirname } from "node:path";
 import os from "node:os";
-import { fileURLToPath } from "node:url";
+import path, { dirname } from "node:path";
 import { PassThrough } from "node:stream";
+import { fileURLToPath } from "node:url";
+import { type ElectronApplication, test as base, expect as baseExpect, _electron as electron } from "@playwright/test";
 
 /**
  * A PassThrough stream that captures all data written to it.
@@ -50,16 +50,13 @@ export const test = base.extend<Fixtures>({
     extraEnv: {},
     extraArgs: [],
 
-    // eslint-disable-next-line no-empty-pattern
     stdout: async ({}, use) => {
         await use(new CapturedPassThrough());
     },
-    // eslint-disable-next-line no-empty-pattern
     stderr: async ({}, use) => {
         await use(new CapturedPassThrough());
     },
 
-    // eslint-disable-next-line no-empty-pattern
     tmpDir: async ({}, use) => {
         const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), "element-desktop-tests-"));
         console.log("Using temp profile directory: ", tmpDir);

scripts/copy-res.ts

@@ -2,10 +2,10 @@
 
 // copies resources into the lib directory.
 
-import parseArgs from "minimist";
-import * as chokidar from "chokidar";
-import * as path from "node:path";
 import * as fs from "node:fs";
+import * as path from "node:path";
+import * as chokidar from "chokidar";
+import parseArgs from "minimist";
 
 const argv = parseArgs(process.argv.slice(2), {});
 

scripts/fetch-package.ts

@@ -1,11 +1,11 @@
 #!/usr/bin/env -S npx tsx --resolveJsonModule
 
-import * as path from "node:path";
-import { createWriteStream, promises as fs } from "node:fs";
 import * as childProcess from "node:child_process";
-import * as tar from "tar";
-import * as asar from "@electron/asar";
+import { promises as fs, createWriteStream } from "node:fs";
+import * as path from "node:path";
 import { promises as stream } from "node:stream";
+import * as asar from "@electron/asar";
+import * as tar from "tar";
 
 import riotDesktopPackageJson from "../package.json";
 import { setPackageVersion } from "./set-version.js";
@@ -27,7 +27,9 @@ async function downloadToFile(url: string, filename: string): Promise<void> {
         console.error(e);
         try {
             await fs.unlink(filename);
-        } catch {}
+        } catch {
+            // ignore
+        }
         throw e;
     }
 }
@@ -151,7 +153,9 @@ async function main(): Promise<number | undefined> {
         await fs.opendir(expectedDeployDir);
         console.log(expectedDeployDir + "already exists");
         haveDeploy = true;
-    } catch {}
+    } catch {
+        // ignore
+    }
 
     if (!haveDeploy) {
         const outPath = path.join(pkgDir, filename);
@@ -207,7 +211,9 @@ async function main(): Promise<number | undefined> {
         await fs.stat(ASAR_PATH);
         console.log(ASAR_PATH + " already present: removing");
         await fs.unlink(ASAR_PATH);
-    } catch {}
+    } catch {
+        // ignore
+    }
 
     if (cfgDir.length) {
         const configJsonSource = path.join(cfgDir, "config.json");

scripts/hak/copy.ts

@@ -6,14 +6,14 @@ SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Com
 Please see LICENSE files in the repository root for full details.
 */
 
-import path from "node:path";
-import fsProm from "node:fs/promises";
 import childProcess from "node:child_process";
+import fsProm from "node:fs/promises";
+import path from "node:path";
 import { glob } from "glob";
 import { mkdirp } from "mkdirp";
 
-import type HakEnv from "./hakEnv.js";
 import type { DependencyInfo } from "./dep.js";
+import type HakEnv from "./hakEnv.js";
 
 export default async function copy(hakEnv: HakEnv, moduleInfo: DependencyInfo): Promise<void> {
     if (moduleInfo.cfg.copy) {

scripts/hak/fetch.ts

@@ -9,8 +9,8 @@ Please see LICENSE files in the repository root for full details.
 import fsProm from "node:fs/promises";
 import pacote from "pacote";
 
-import type HakEnv from "./hakEnv.js";
 import type { DependencyInfo } from "./dep.js";
+import type HakEnv from "./hakEnv.js";
 
 export default async function fetch(hakEnv: HakEnv, moduleInfo: DependencyInfo): Promise<void> {
     let haveModuleBuildDir;

scripts/hak/hakEnv.ts

@@ -6,12 +6,12 @@ SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Com
 Please see LICENSE files in the repository root for full details.
 */
 
-import path from "node:path";
+import childProcess, { type SpawnOptions } from "node:child_process";
 import os from "node:os";
+import path from "node:path";
 import { getElectronVersionFromInstalled } from "app-builder-lib/out/electron/electronVersion.js";
-import childProcess, { type SpawnOptions } from "node:child_process";
 
-import { type Arch, type Target, TARGETS, getHost, isHostId, type TargetId } from "./target.js";
+import { type Arch, TARGETS, type Target, type TargetId, getHost, isHostId } from "./target.js";
 
 async function getRuntimeVersion(projectRoot: string): Promise<string> {
     const electronVersion = await getElectronVersionFromInstalled(projectRoot);