Skip to content

Commit f733c2e

Browse files
authored
Switch to shiftkey/node-keytar as it has NAPI 10 updates (#2172)
* Test keytar-forked Signed-off-by: Michael Telatynski <[email protected]> * Iterate Signed-off-by: Michael Telatynski <[email protected]> * Leverage electron-builder to build keytar rather than hak Signed-off-by: Michael Telatynski <[email protected]> * Add logging Signed-off-by: Michael Telatynski <[email protected]> * Iterate Signed-off-by: Michael Telatynski <[email protected]> * Update imports Signed-off-by: Michael Telatynski <[email protected]> * Update knip.ts --------- Signed-off-by: Michael Telatynski <[email protected]>
1 parent 1496f3d commit f733c2e

File tree

6 files changed

+16
-17
lines changed

6 files changed

+16
-17
lines changed

.node-version

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v22.13.1
1+
v22.14.0

knip.ts

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ export default {
55
project: ["**/*.{js,ts}"],
66
ignoreDependencies: [
77
// Brought in via hak scripts
8-
"keytar",
98
"matrix-seshat",
109
// Required for `action-validator`
1110
"@action-validator/*",

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"type": "module",
1616
"files": [],
1717
"engines": {
18-
"node": ">=18.0.0 <=22.13.1"
18+
"node": ">=18.0.0"
1919
},
2020
"scripts": {
2121
"i18n": "matrix-gen-i18n && yarn i18n:sort && yarn i18n:lint",
@@ -63,7 +63,7 @@
6363
"counterpart": "^0.18.6",
6464
"electron-store": "^10.0.0",
6565
"electron-window-state": "^5.0.3",
66-
"keytar": "^7.9.0",
66+
"keytar-forked": "7.10.0",
6767
"minimist": "^1.2.6",
6868
"png-to-ico": "^2.1.1",
6969
"uuid": "^11.0.0"

src/ipc.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Please see LICENSE files in the repository root for full details.
77

88
import { app, autoUpdater, desktopCapturer, ipcMain, powerSaveBlocker, TouchBar, nativeImage } from "electron";
99
import { relaunchApp } from "@standardnotes/electron-clear-data";
10-
import keytar from "keytar";
10+
import keytar from "keytar-forked";
1111

1212
import IpcMainEvent = Electron.IpcMainEvent;
1313
import { recordSSOSession } from "./protocol.js";

src/seshat.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Please see LICENSE files in the repository root for full details.
88
import { app, ipcMain } from "electron";
99
import { promises as afs } from "node:fs";
1010
import path from "node:path";
11-
import keytar from "keytar";
11+
import keytar from "keytar-forked";
1212

1313
import type {
1414
Seshat as SeshatType,

yarn.lock

+11-11
Original file line numberDiff line numberDiff line change
@@ -5123,13 +5123,13 @@ jszip@^3.1.0:
51235123
readable-stream "~2.3.6"
51245124
setimmediate "^1.0.5"
51255125

5126-
keytar@^7.9.0:
5127-
version "7.9.0"
5128-
resolved "https://registry.yarnpkg.com/keytar/-/keytar-7.9.0.tgz#4c6225708f51b50cbf77c5aae81721964c2918cb"
5129-
integrity sha512-VPD8mtVtm5JNtA2AErl6Chp06JBfy7diFQ7TQQhdpWOl6MrCRB+eRbvAZUsbGQS9kiMq0coJsy0W0vHpDCkWsQ==
5126+
5127+
version "7.10.0"
5128+
resolved "https://registry.yarnpkg.com/keytar-forked/-/keytar-forked-7.10.0.tgz#dbb78e16b18a40fc61df58124228855a7e8c912d"
5129+
integrity sha512-MrH3Id3Bjf4av3zGihBK62NucgBOVbTzchnSRPtA14sWRj9xu7roFa9NddlxC6Nt98EdrQpu04MZXnuusV+b5w==
51305130
dependencies:
5131-
node-addon-api "^4.3.0"
5132-
prebuild-install "^7.0.1"
5131+
node-addon-api "^8.3.0"
5132+
prebuild-install "^7.1.3"
51335133

51345134
keyv@^4.0.0, keyv@^4.5.3:
51355135
version "4.5.4"
@@ -5643,10 +5643,10 @@ node-addon-api@^1.6.3:
56435643
resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-1.7.2.tgz#3df30b95720b53c24e59948b49532b662444f54d"
56445644
integrity sha512-ibPK3iA+vaY1eEjESkQkM0BbCqFOaZMiXRTtdB0u7b4djtY6JnsjvPdUHVMg6xQt3B8fpTTWHI9A+ADjM9frzg==
56455645

5646-
node-addon-api@^4.3.0:
5647-
version "4.3.0"
5648-
resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-4.3.0.tgz#52a1a0b475193e0928e98e0426a0d1254782b77f"
5649-
integrity sha512-73sE9+3UaLYYFmDsFZnqCInzPyh3MqIwZO9cw58yIqAZhONrrabrYyYe3TuIqtIiOuTXVhsGau8hcrhhwSsDIQ==
5646+
node-addon-api@^8.3.0:
5647+
version "8.3.1"
5648+
resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-8.3.1.tgz#53bc8a4f8dbde3de787b9828059da94ba9fd4eed"
5649+
integrity sha512-lytcDEdxKjGJPTLEfW4mYMigRezMlyJY8W4wxJK8zE533Jlb8L8dRuObJFWg2P+AuOIxoCgKF+2Oq4d4Zd0OUA==
56505650

56515651
node-api-version@^0.2.0:
56525652
version "0.2.0"
@@ -6253,7 +6253,7 @@ postject@^1.0.0-alpha.6:
62536253
dependencies:
62546254
commander "^9.4.0"
62556255

6256-
prebuild-install@^7.0.1:
6256+
prebuild-install@^7.1.3:
62576257
version "7.1.3"
62586258
resolved "https://registry.yarnpkg.com/prebuild-install/-/prebuild-install-7.1.3.tgz#d630abad2b147443f20a212917beae68b8092eec"
62596259
integrity sha512-8Mf2cbV7x1cXPUILADGI3wuhfqWvtiLA1iclTDbFRZkgRQS0NqsPZphna9V+HyTEadheuPmjaJMsbzKQFOzLug==

0 commit comments

Comments
 (0)