Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mask-image with Compound icons and component (when they became ready) #25476

Closed
luixxiul opened this issue May 30, 2023 · 7 comments
Closed
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Enhancement

Comments

@luixxiul
Copy link

luixxiul commented May 30, 2023

Your use case

What would you like to do?

Replace mask-image on CSS files with Compound icons and component, when they became ready.

Why would you like to do it?

Because Compound stuff is widely believed to save the design, magically or not :-D

How would you like to achieve it?

Have you considered any alternatives?

No response

Additional context

@weeman1337 weeman1337 added S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels May 31, 2023
@weeman1337
Copy link
Contributor

weeman1337 commented May 31, 2023

I would rather say „Replace mask-imag with Comound Icons“ …

@luixxiul
Copy link
Author

Are those "Compound icons" going to be implemented by using Icon component? If so, it should be fine to start replacing existing mask-image declarations, if not all, so that you will able to start using the Compound icons just by changing from values.

Thanks!

@weeman1337
Copy link
Contributor

My guess is that there will be some kind of component. The current Icon component in Element Web / React SDK is based on Webpack SVG loader: https://github.com/matrix-org/matrix-react-sdk/blob/develop/docs/icons.md

Most likely the Compound component is going to be different. Compound doesn't currently expose much about icons: https://compound.element.io/?path=/story/compound-web_icon--icon

I would recommend looking at this again when the compound symbols are ready.

@weeman1337
Copy link
Contributor

→ I will mention that we should make more information about Compound publicly available!

@luixxiul
Copy link
Author

I understood. As the uncertainty around that area can be removed only by internal members, please update asap when something becomes clearer. Thanks in advance.

@luixxiul luixxiul changed the title Replace mask-image with Icon component? Replace mask-image with Compound icons (when they became ready) May 31, 2023
@luixxiul luixxiul changed the title Replace mask-image with Compound icons (when they became ready) Replace mask-image with Compound icons and component (when they became ready) May 31, 2023
@luixxiul
Copy link
Author

For reference, the current set has been added with matrix-org/matrix-react-sdk#10292.

@weeman1337
Copy link
Contributor

For reference, the current set has been added with matrix-org/matrix-react-sdk#10292.

That was me doing some clean-up. I didn't know that the padding should be included in each of the icons instead of adding it by a CSS class. These were all icons that I had newly added.

@luixxiul luixxiul closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants