-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mask-image
with Compound icons and component (when they became ready)
#25476
Comments
I would rather say „Replace |
Are those "Compound icons" going to be implemented by using Thanks! |
My guess is that there will be some kind of component. The current Icon component in Element Web / React SDK is based on Webpack SVG loader: https://github.com/matrix-org/matrix-react-sdk/blob/develop/docs/icons.md Most likely the Compound component is going to be different. Compound doesn't currently expose much about icons: https://compound.element.io/?path=/story/compound-web_icon--icon I would recommend looking at this again when the compound symbols are ready. |
→ I will mention that we should make more information about Compound publicly available! |
I understood. As the uncertainty around that area can be removed only by internal members, please update asap when something becomes clearer. Thanks in advance. |
mask-image
with Icon
component?mask-image
with Compound icons (when they became ready)
mask-image
with Compound icons (when they became ready)mask-image
with Compound icons and component (when they became ready)
For reference, the current set has been added with matrix-org/matrix-react-sdk#10292. |
That was me doing some clean-up. I didn't know that the padding should be included in each of the icons instead of adding it by a CSS class. These were all icons that I had newly added. |
Your use case
What would you like to do?
Replace
mask-image
on CSS files with Compound icons and component, when they became ready.Why would you like to do it?
Because Compound stuff is widely believed to save the design, magically or not :-D
How would you like to achieve it?
Have you considered any alternatives?
No response
Additional context
The text was updated successfully, but these errors were encountered: