Skip to content

Commit ec35064

Browse files
committed
Merge pull request #2050 from jwarwick/version_spec
Updated specs in Version
2 parents 73dc453 + e4aa6e1 commit ec35064

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

lib/elixir/lib/version.ex

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ defmodule Version do
6868
Returns `true` if `version` satisfies `requirement`, `false` otherwise.
6969
Raises a `Version.InvalidRequirement` exception if `requirement` is not
7070
parseable, or `Version.InvalidVersion` if `version` is not parseable.
71-
If given an already parsed version and requirement this function wont
71+
If given an already parsed version and requirement this function won't
7272
raise.
7373
7474
## Examples
@@ -107,7 +107,7 @@ defmodule Version do
107107
is returned
108108
109109
Raises a `Version.InvalidVersion` exception if `version` is not parseable.
110-
If given an already parsed version this function wont raise.
110+
If given an already parsed version this function won't raise.
111111
112112
## Examples
113113
@@ -280,7 +280,7 @@ defmodule Version do
280280
(?:\+([\d\w\-]+))? # build
281281
$/x
282282

283-
@spec parse_requirement(String.t) :: Version.Requirement.t
283+
@spec parse_requirement(String.t) :: {:ok, Version.Requirement.t} | :error
284284
def parse_requirement(source) do
285285
lexed = lexer(source, [])
286286
to_matchspec(lexed)
@@ -289,7 +289,7 @@ defmodule Version do
289289
defp nillify(""), do: nil
290290
defp nillify(o), do: o
291291

292-
@spec parse_version(String.t) :: Version.matchable
292+
@spec parse_version(String.t) :: {:ok, Version.matchable} | :error
293293
def parse_version(string, approximate? \\ false) when is_binary(string) do
294294
if parsed = Regex.run(@version_regex, string) do
295295
destructure [_, major, minor, patch, pre], parsed
@@ -473,7 +473,6 @@ defmodule Version do
473473
end
474474

475475
defp matchable_to_string({ major, minor, patch, pre }) do
476-
minor = if minor, do: "#{minor}", else: "0"
477476
patch = if patch, do: "#{patch}", else: "0"
478477
pre = if pre != [], do: "-#{Enum.join(pre, ".")}"
479478
"#{major}.#{minor}.#{patch}#{pre}"

0 commit comments

Comments
 (0)