Error: wrong-number-of-arguments ((2 . 2) 1), elsa-process-file

[jcs090218]

Funny thing is I've eask lint elsa test in emacs-eask/cli repo, that's how I discovered this bug.

Error Version: 20230213.1902, see log
Previous working version: 20230212.1959, see log

Backtrace

Running Eask in the development environment
Press Ctrl+C to cancel.

Executing script inside Emacs...

  Checking Emacs version 29.0.50... done!
  Checking system windows-nt... done!
  Try constructing the package-descriptor (openai.el)... succeeded!
  Loading Eask file in d:/_workspace/openai/Eask... done!

Loading package information... done
  - Installing elsa (20230213.1902)... done

`openai.el` with elsa (20230213.1902)

Error: wrong-number-of-arguments ((2 . 2) 1)
  debug-early-backtrace()
  debug-early(error (wrong-number-of-arguments (2 . 2) 1))
  elsa-process-file("d:/_workspace/openai/openai.el")
  (eieio-oref (elsa-process-file filename) 'errors)
  (setq errors (eieio-oref (elsa-process-file filename) 'errors))
  ...

Let me know if you want a CI test for this. I would love to work on this! ;)

[Fuco1]

I must've pushed some wrong version and probably melpa built it 🤦‍♂️ It should be fixed on the current version.

What do you have in mind with the CI test? To lint elsa package with elsa? We can add that but as optional, since it will still have a lot of errors which aren't really errors.

[jcs090218]

I must've pushed some wrong version and probably melpa built it 🤦‍♂️ It should be fixed on the current version.

Thanks for fixing it! ;)

What do you have in mind with the CI test? To lint elsa package with elsa?

Probably a dummy package for elsa to lint. To make sure there won't be errors running Elsa .

We can add that but as optional, since it will still have a lot of errors which aren't really errors.

The purpose of the test is to prevent activation errors, but not the logic errors. What errors are you referring to?

[jcs090218]

Oh, I realized the error is actually came from the eask's command eask lint elsa... Sorry I was being stupid. eask exec elsa works fine.

Sorry for the noise. 😓

[Fuco1]

Still this

Probably a dummy package for elsa to lint. To make sure there won't be errors running Elsa .

sounds like a good idea

[jcs090218]

sounds like a good idea

Awesome! Will open a PR for this!

[jcs090218]

I'm working on the activation test in my fork, see jcs-PR#3.

There is an error on the latest MELPA version, which only occurs in Windows. See https://github.com/jcs-PR/Elsa/actions/runs/4246412790/jobs/7383187727#step:7:222

Log here

.eask/29.0.60/elpa/elsa-0.1.0/elsa-types.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-type)(other elsa-type)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-error.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-message)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-error.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-message)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-state.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-declarations)(str elsa-cl-structure)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-state.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-declarations)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-state.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-declarations)(def elsa-defun)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-state.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-declarations)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-state.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-declarations)(def elsa-defvar)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-state.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-declarations)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-state.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-declarations)(name symbol)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-state.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-declarations)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-reader.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-form)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-reader.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-form)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-reader.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-form)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-check.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-check)(form elsa-form)(scope elsa-scope)(state elsa-state)
.eask/29.0.60/elpa/elsa-0.1.0/elsa-check.el: Warning: Non-symbol arguments to cl-defgeneric: (this elsa-check)(form elsa-form)(scope elsa-scope)(state elsa-state)

Error: wrong-type-argument ((or eieio-object cl-structure-object oclosure) elsa-global-state)
  debug-early-backtrace()
  debug-early(error (wrong-type-argument (or eieio-object cl-structure-object oclosure) elsa-global-state))
  eieio-oset(elsa-global-state project-directory "./")
  (let ((dependencies (cons "subr" (elsa-get-dependencies file))) (visited nil) (file-state nil)) (eieio-oset global-state 'project-directory (f-parent file)) (eieio-oset global-state 'processed-file-index 1) (eieio-oset global-state 'number-of-files (length dependencies)) (let ((tail dependencies)) (while tail (let ((dep (car tail))) (let* ((dep (replace-regexp-in-string "-CIRCULAR\\'" "" dep)) (elsa-cache-file (elsa--get-cache-file-name global-state dep))) (let* ((library (and t (file-truename (if (f-exists? dep) dep (elsa--find-dependency dep)))))) (if library (if (and (or (member library visited) (member library already-loaded)) (not (file-newer-than-file-p library elsa-cache-file))) (elsa-log "[%s] Skipping already processed dependency %s (was circular)" (elsa-global-state-get-counter global-state) dep) (setq visited (cons library visited)) (if (require (intern (concat "elsa-typed-" (replace-regexp-in-string ".el\\'" "" dep))) nil t) (progn (elsa-log "%sAutoloading types for %s" (make-string (elsa-global-state-prefix-length global-state 3) 32) dep))) (if (require (intern (concat "elsa-extension-" (replace-regexp-in-string ".el\\'" "" dep))) nil t) (progn (elsa-log "%sAutoloading extension for %s" (make-string (elsa-global-state-prefix-length global-state 3) 32) dep))) (if (file-newer-than-file-p library elsa-cache-file) (let ((state (elsa-process-file library global-state))) (if (equal dep "subr") (progn (eieio-oset state 'provide (list 'subr)))) (elsa-save-cache state global-state) (elsa-state-update-global state global-state) (setq file-state state)) (elsa-log "[%s] Loading %s from cache %s" (elsa-global-state-get-counter global-state) dep elsa-cache-file) (load (f-no-ext elsa-cache-file) t t)))))) (let* ((v global-state)) (eieio-oset v 'processed-file-index (+ (eieio-oref v 'processed-file-index) 1))) (setq tail (cdr tail))))) (eieio-oset file-state 'dependencies visited) file-state)
  elsa-analyse-file("dummy-package.el" elsa-global-state)
  (eieio-oref (elsa-analyse-file file elsa-global-state) 'errors)
  (reverse (eieio-oref (elsa-analyse-file file elsa-global-state) 'errors))
  (let ((list (reverse (eieio-oref (elsa-analyse-file file elsa-global-state) 'errors))) (i 0)) (while list (let ((it (car-safe (prog1 list (setq list (cdr list))))) (it-index i)) (ignore it it-index) (princ (concat file ":" (elsa-message-format it)))) (setq i (1+ i))))
  (let ((file (car tail))) (let ((list (reverse (eieio-oref (elsa-analyse-file file elsa-global-state) 'errors))) (i 0)) (while list (let ((it (car-safe (prog1 list (setq list (cdr list))))) (it-index i)) (ignore it it-index) (princ (concat file ":" (elsa-message-format it)))) (setq i (1+ i)))) (setq tail (cdr tail)))
  (while tail (let ((file (car tail))) (let ((list (reverse (eieio-oref (elsa-analyse-file file elsa-global-state) 'errors))) (i 0)) (while list (let ((it (car-safe (prog1 list (setq list (cdr list))))) (it-index i)) (ignore it it-index) (princ (concat file ":" (elsa-message-format it)))) (setq i (1+ i)))) (setq tail (cdr tail))))
  (let ((tail command-line-args-left)) (while tail (let ((file (car tail))) (let ((list (reverse (eieio-oref (elsa-analyse-file file elsa-global-state) 'errors))) (i 0)) (while list (let ((it (car-safe (prog1 list (setq list (cdr list))))) (it-index i)) (ignore it it-index) (princ (concat file ":" (elsa-message-format it)))) (setq i (1+ i)))) (setq tail (cdr tail)))))
  elsa-run()
  command-line-1(("--no-splash" "--eval" "(setq enable-dir-local-variables nil)" "--load=elsa" "--funcall=elsa-run" "dummy-package.el"))
  command-line()
  normal-top-level()
Wrong type argument: (or eieio-object cl-structure-object oclosure), elsa-global-state

undefined:0

Exit with code: 4294967295
(Use `eask --trace-uncaught ...` to show where the exception was thrown)

Here are my few guesses:

1. bin/elsa.bat acts differently
2. Elsa's master branch doesn't handle Windows (I think it was working in MELPA 20230212.1959)

You've recently added 13 new commits. Would those solve this error? 🤔