Skip to content

Commit 54f9ec8

Browse files
committed
Use global-variable instead of closure
I think we need not to use closure for those functions.
1 parent 8ada02e commit 54f9ec8

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

init-loader.el

+13-9
Original file line numberDiff line numberDiff line change
@@ -186,15 +186,19 @@ example, 00_foo.el, 01_bar.el ... 99_keybinds.el."
186186
(expand-file-name (file-symlink-p dir)))
187187
(t (expand-file-name dir))))
188188

189-
(declare-function init-loader-log "init-loader.el" (&optional s) t)
190-
(lexical-let (logs)
191-
(defun init-loader-log (&optional s)
192-
(if s (and (stringp s) (push s logs)) (mapconcat 'identity (reverse logs) "\n"))))
193-
194-
(declare-function init-loader-error-log "init-loader.el" (&optional s) t)
195-
(lexical-let (err-logs)
196-
(defun init-loader-error-log (&optional s)
197-
(if s (and (stringp s) (push s err-logs)) (mapconcat 'identity (reverse err-logs) "\n"))))
189+
(defvar init-loader--log-buffer nil)
190+
(defun init-loader-log (&optional msg)
191+
(if msg
192+
(when (stringp msg)
193+
(push msg init-loader--log-buffer))
194+
(mapconcat 'identity (reverse init-loader--log-buffer) "\n")))
195+
196+
(defvar init-loader--error-log-buffer nil)
197+
(defun init-loader-error-log (&optional msg)
198+
(if msg
199+
(when (stringp msg)
200+
(push msg init-loader--error-log-buffer))
201+
(mapconcat 'identity (reverse init-loader--error-log-buffer) "\n")))
198202

199203
(defvar init-loader-before-compile-hook nil)
200204
(defun init-loader-load-file (file)

0 commit comments

Comments
 (0)