Skip to content

Commit 084c922

Browse files
update the code based on telemetry data changes
1 parent e052e28 commit 084c922

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

Diff for: bin/cli.js

+12-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@ const finder = require('find-package-json');
77
const recast = require('ember-template-recast');
88
const fs = require('fs');
99
const path = require('path');
10-
const { appResolver, detectTypeAndName } = require('../transforms/no-implicit-this/helpers/util');
10+
const {
11+
appResolver,
12+
detectTypeAndName,
13+
TELEMETRY_KEY,
14+
} = require('../transforms/no-implicit-this/helpers/util');
1115
const { gatherSingleTelemetryForUrl, getTelemetry } = require('ember-codemods-telemetry-helpers');
1216
const appLocation = process.argv[2];
1317
const args = process.argv.slice(3);
@@ -93,7 +97,13 @@ function findAppName(f) {
9397
debug('Gathering telemetry data from %s ...', appLocation);
9498

9599
// This is for collecting metadata for the app just once to generate the map of lookupnames to local properties
96-
await gatherSingleTelemetryForUrl(appLocation, appResolver, lookupNames, appName);
100+
await gatherSingleTelemetryForUrl(
101+
appLocation,
102+
{ telemetryKey: TELEMETRY_KEY },
103+
appResolver,
104+
lookupNames,
105+
appName
106+
);
97107

98108
let telemetry = getTelemetry();
99109

Diff for: transforms/no-implicit-this/__testfixtures__/-mock-telemetry.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"single-telemetry": {
2+
"telemetry-data": {
33
"component:handlebars-with-prefix-component-properties-only": {
44
"type": "Component",
55
"localProperties": ["baz", "bang"],

Diff for: transforms/no-implicit-this/helpers/plugin.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ const path = require('path');
66
// sorta. telemetry needs to be defined.
77
// telemtry can be populated with -mock-telemetry.json
88
const KNOWN_HELPERS = require('./known-helpers');
9+
const { TELEMETRY_KEY } = require('./util');
910

1011
function getTelemetryObjByName(name, telemetry) {
1112
let telemetryLookupName = Object.keys(telemetry).find(item => item.split(':').pop() === name);
@@ -18,7 +19,7 @@ function transform(root, options = {}) {
1819
let b = recast.builders;
1920

2021
let scopedParams = [];
21-
let telemetry = options.telemetry ? options.telemetry['single-telemetry'] : {};
22+
let telemetry = options.telemetry ? options.telemetry[TELEMETRY_KEY] : {};
2223

2324
let customHelpers = options.customHelpers || [];
2425

Diff for: transforms/no-implicit-this/helpers/util.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
const path = require('path');
22
const globby = require('globby');
3+
const TELEMETRY_KEY = 'telemetry-data';
34

45
/**
56
* Generates a lookup name for a backing js class.
@@ -112,4 +113,4 @@ function appResolver(lookupNames, currAppName) {
112113
return mapping;
113114
}
114115

115-
module.exports = { appResolver, detectTypeAndName };
116+
module.exports = { appResolver, detectTypeAndName, TELEMETRY_KEY };

0 commit comments

Comments
 (0)