Multiple component invocations got this. added

[vlascik]

Before:

{{nav/web-top-bar}}
{{nav/web-header}}
<div class="asdf">
  {{liquid-outlet}}
  {{liquid-modal}}
</div>

{{nav/web-footer}}

After:

{{this.nav/web-top-bar}}
{{this.nav/web-header}}
<div class="asdf">
  {{liquid-outlet}}
  {{this.liquid-modal}}
</div>

{{this.nav/web-footer}}

Current github master (3df3c19) + current master of telemetry-helpers (as the currently released version breaks on Windows)

[NullVoxPopuli]

What command did you use to run the codemod?
Do these components exist in the app or an add-on?

[vlascik]

node p:\Git\ember-no-implicit-this-codemod\bin\cli.js http://localhost:4200/ app/**/*.hbs

nav/*components come from the app, liquid-modal comes from liquid-fire addon (https://github.com/ember-animation/liquid-fire-core/blob/master/app/templates/components/liquid-modal.hbs)

[IgorKvasn]

I have the same problem - it looks like this codemod does not differenciate between properties and non-angle bracket components

I was running command: npx ember-no-implicit-this-codemod http://localhost:4200 app/

edit: I just noticed, that sometimes components are correctly left alone (not prefixed by this.) - will investigate further
as far as I noticed, components without template are prefixed with this. (maybe it's just a coincidence)

[knownasilya]

Same issue here, but it seems rare. Seems like angle bracket codemod should be run first as a workaround.

[Techn1x]

Have also run into this, with components defined within the app errornously getting this added
{{this.debug/save-translations}}
{{this.side-nav/reading/teacher-toolkit}}
{{this.side-nav/reading/assignments/re}}
{{this.side-nav/reading/assignments/rex}}
{{this.side-nav/maths/teacher-toolkit}}
{{this.side-nav/maths/assignments}}

Interestingly, plenty of other side-nav components didn't get incorrectly this'd. Nothing obviously different between the above ^ components and the others..

EDIT: I do use pods, so could be that I guess 🤷 would be nice if the readme listed the limitations and what to look out for, it's pretty bare

[apellerano-pw]

since variable names don't contain hyphen (-) or forward slash (/) here's some regexes to scan for erroneous this. added in front of components with those characters

\{\{this\.[a-z]+-
\{\{this\.[a-z\-]+/

if you have components with single-word names, there's no way to differentiate them from variables. but you can at least limit the search space a bit by excluding capital letters. your variable names sometimes have them for camelCase, but a component/helper/modifier would never have capital letters since they're kebab-case

(don't use case insensitive flag)
\{\{this\.[a-z]+\}\}

caveat: I've only seen this issue occur on straightforward {{foo}} component invocations; never when a component has args provided