From 64fa2eedfb7052ad5ca0b725da2d58c30880a0ae Mon Sep 17 00:00:00 2001
From: Michael Kerr <michael.kerr@mainmatter.com>
Date: Tue, 23 Apr 2024 16:00:53 +0100
Subject: [PATCH] temp

---
 .../-private/legacy-relationships-support.ts  |  3 +-
 packages/model/addon/-private/record-state.ts |  3 ++
 .../store/addon/-private/instance-cache.ts    | 36 +++++++++++++++++++
 3 files changed, 41 insertions(+), 1 deletion(-)

diff --git a/packages/model/addon/-private/legacy-relationships-support.ts b/packages/model/addon/-private/legacy-relationships-support.ts
index 282a8228ddc..4af9d6b0ed4 100644
--- a/packages/model/addon/-private/legacy-relationships-support.ts
+++ b/packages/model/addon/-private/legacy-relationships-support.ts
@@ -127,10 +127,11 @@ export class LegacySupport {
       }
 
       let promise = this._findBelongsTo(key, resource, relationshipMeta, options);
+      const isLoaded = relatedIdentifier && store._instanceCache.recordIsLoaded(relatedIdentifier);
 
       return this._updatePromiseProxyFor('belongsTo', key, {
         promise,
-        content: relatedIdentifier ? store._instanceCache.getRecord(relatedIdentifier) : null,
+        content: isLoaded ? store._instanceCache.getRecord(relatedIdentifier!) : null,
         _belongsToState,
       });
     } else {
diff --git a/packages/model/addon/-private/record-state.ts b/packages/model/addon/-private/record-state.ts
index 37434f920f5..0ec3fbcc04f 100644
--- a/packages/model/addon/-private/record-state.ts
+++ b/packages/model/addon/-private/record-state.ts
@@ -233,6 +233,9 @@ export default class RecordState {
     notifications.subscribe(identity, (identifier: StableRecordIdentifier, type: NotificationType, key?: string) => {
       switch (type) {
         case 'state':
+          this.notify('isSaved');
+          this.notify('isLoaded');
+          this.notify('isEmpty');
           this.notify('isNew');
           this.notify('isDeleted');
           this.notify('isDirty');
diff --git a/packages/store/addon/-private/instance-cache.ts b/packages/store/addon/-private/instance-cache.ts
index b0b06a4ca51..157c0832e08 100644
--- a/packages/store/addon/-private/instance-cache.ts
+++ b/packages/store/addon/-private/instance-cache.ts
@@ -245,6 +245,42 @@ export class InstanceCache {
     return this._internalModelForResource(identifier);
   }
 
+  recordIsLoaded(identifier: StableRecordIdentifier, filterDeleted: boolean = false) {
+    const recordData = this.#instances.recordData.get(identifier);
+    if (!recordData) {
+      return false;
+    }
+    const isNew = recordData.isNew?.();
+    const isEmpty = recordData.isEmpty?.();
+
+    // if we are new we must consider ourselves loaded
+    if (isNew) {
+      return !recordData.isDeleted?.();
+    }
+    // even if we have a past request, if we are now empty we are not loaded
+    // typically this is true after an unloadRecord call
+
+    // if we are not empty, not new && we have a fulfilled request then we are loaded
+    // we should consider allowing for something to be loaded that is simply "not empty".
+    // which is how RecordState currently handles this case; however, RecordState is buggy
+    // in that it does not account for unloading.
+    return filterDeleted && recordData.isDeletionCommitted?.() ? false : !isEmpty;
+
+    /*
+    const req = this.store.getRequestStateService();
+    const fulfilled = req.getLastRequestForRecord(identifier);
+    const isLocallyLoaded = !isEmpty;
+    const isLoading =
+      !isLocallyLoaded &&
+      fulfilled === null &&
+      req.getPendingRequestsForRecord(identifier).some((req) => req.type === 'query');
+    if (isEmpty || (filterDeleted && recordData.isDeletionCommitted(identifier)) || isLoading) {
+      return false;
+    }
+    return true;
+    */
+  }
+
   createSnapshot(identifier: StableRecordIdentifier, options: FindOptions = {}): Snapshot {
     return new Snapshot(options, identifier, this.store);
   }