Skip to content

TypeScript error because @glimmer/tracking depends on a very old @glimmer/validator #20502

Open
@boris-petrov

Description

@boris-petrov

🐞 Describe the Bug

Installing Ember 5.1.2 on pnpm leads to:

node_modules/.pnpm/@[email protected]/node_modules/@glimmer/manager/dist/types/lib/public/modifier.d.ts:45:5 - error TS2416: Property 'getTag' in type 'CustomModifierManager<O, ModifierInstance>' is not assignable to the same property in base type 'InternalModifierManager<CustomModifierState<ModifierInstance>, object>'.
  Type '({ tag }: CustomModifierState<ModifierInstance>) => UpdatableTag' is not assignable to type '(modifier: CustomModifierState<ModifierInstance>) => UpdatableTag | null'.
    Type 'MonomorphicTagBase<MonomorphicTagTypes.Updatable>' is missing the following properties from type 'MonomorphicTagBase<MonomorphicTagTypes.Updatable>': [TYPE], [COMPUTE]

45     getTag({ tag }: CustomModifierState<ModifierInstance>): UpdatableTag;
       ~~~~~~

🔬 Minimal Reproduction

Repo.

Run pnpm install and then ./node_modules/.bin/tsc.

😕 Actual Behavior

Type errors in node_modules.

🤔 Expected Behavior

No errors.

🌍 Environment

  • Ember: 5.1.2
  • Node.js/npm: 20.3.1/9.7.2
  • OS: Linux
  • Browser: N/A

cc @chriskrycho, @NullVoxPopuli

A discussion:

https://discord.com/channels/480462759797063690/1125100083277463763

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions