Improve drag-to-select text (add margins) #5797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hankjordan
changed the title
emilk
reviewed
Mar 21, 2025
Comment on lines
826
to
832
| if let Some(first_row) = self.rows.first() { | ||
| if pos.y < first_row.min_y() { | ||
| if pos.y < first_row.min_y() - 5.0 { | ||
| return self.begin(); | ||
| } | ||
| } | ||
| if let Some(last_row) = self.rows.last() { | ||
| if last_row.max_y() < pos.y { | ||
| if last_row.max_y() + 5.0 < pos.y { |
There was a problem hiding this comment.
Let's give the 5.0 a name (const VMARGIN: f32 or something) and explain why its there 🙏
|
Preview available at https://egui-pr-preview.github.io/pr/5797-hjgalley-interact-margin |
emilk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might want to draw from
interaction.interact_radiusstyle instead of hard-coding the margin, but I didn't want to create a breaking change. If desired, I can follow up with a separate PR to address that concern.TextEdit#5796