Skip to content

ALLOC_NORMAL, ALLOC_STACK, allocate, and allocateUTF8OnStack are deprecated #23926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lovasoa opened this issue Mar 14, 2025 · 6 comments
Closed

Comments

@lovasoa
Copy link
Contributor

lovasoa commented Mar 14, 2025

Hello !
I'm just popping in to open an issue as suggested by the following console warnings:

warning: JS library symbol '$ALLOC_NORMAL' is deprecated. Please open a bug if you have a continuing need for this symbol [-Wdeprecated]
warning: JS library symbol '$ALLOC_STACK' is deprecated. Please open a bug if you have a continuing need for this symbol [-Wdeprecated]
warning: JS library symbol '$allocate' is deprecated. Please open a bug if you have a continuing need for this symbol [-Wdeprecated]
warning: JS library symbol '$allocateUTF8OnStack' is deprecated. Please open a bug if you have a continuing need for this symbol [-Wdeprecated]

sql.js still depends on these functions: https://github.com/sql-js/sql.js/blob/master/src/api.js

@sbc100
Copy link
Collaborator

sbc100 commented Mar 14, 2025

Are you a maintainer of that package? Would you be able to migrate away from these? I'm happy to help with this.

@sbc100
Copy link
Collaborator

sbc100 commented Mar 14, 2025

Have you opened a bug on the sql.js side for this? If not I suggest we do that as the next step.

@lovasoa
Copy link
Contributor Author

lovasoa commented Mar 14, 2025

Hi! Yes, I'm the maintainer, but I have very little bandwidth 😁

Help would indeed be very much appreciated, thank you!

@sbc100
Copy link
Collaborator

sbc100 commented Mar 15, 2025

OK, I'm happy to put together PR.. do you some testing in your CI or are you setup to test if I send a PR?

@lovasoa
Copy link
Contributor Author

lovasoa commented Mar 15, 2025

yes, we have a pretty complete CI !

Thank you.

@sbc100
Copy link
Collaborator

sbc100 commented Apr 8, 2025

I believe this was closed by sql-js/sql.js#606

@sbc100 sbc100 closed this as completed Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants