Skip to content

Commit 390d449

Browse files
committed
Rename upstream directory to simply prebuilt
The name `upstream` doesn't have any meaning anymore now that there is no more fastcomp. It was removed from the SDK names in #1166 and this is the last usage of that name/term.
1 parent ae2664b commit 390d449

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

.gitignore

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@ __pycache__
1515
# File that get download/extracted by emsdk itself
1616
/ccache
1717
/gnu
18-
/upstream
19-
/fastcomp
20-
/fastcomp-clang/
18+
/prebuilt
2119
/llvm
2220
/ninja
2321
/releases

emsdk.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1919,9 +1919,9 @@ def install_sdk(self):
19191919
return False
19201920

19211921
if getattr(self, 'custom_install_script', None) == 'emscripten_npm_install':
1922-
# upstream tools have hardcoded paths that are not stored in emsdk_manifest.json registry
1923-
install_path = 'upstream'
1924-
emscripten_dir = os.path.join(EMSDK_PATH, install_path, 'emscripten')
1922+
# prebuilt sdk tools have hardcoded paths that are not stored in
1923+
# emsdk_manifest.json registry
1924+
emscripten_dir = os.path.join(EMSDK_PATH, 'prebuilt', 'emscripten')
19251925
# Older versions of the sdk did not include the node_modules directory
19261926
# and require `npm ci` to be run post-install
19271927
if not os.path.exists(os.path.join(emscripten_dir, 'node_modules')):
@@ -2244,7 +2244,7 @@ def load_releases_info():
22442244

22452245

22462246
def get_installed_sdk_version():
2247-
version_file = sdk_path(os.path.join('upstream', '.emsdk_version'))
2247+
version_file = sdk_path(os.path.join('prebuilt', '.emsdk_version'))
22482248
if not os.path.exists(version_file):
22492249
return None
22502250
with open(version_file) as f:

emsdk_manifest.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"macos_url": "https://storage.googleapis.com/webassembly/emscripten-releases-builds/mac/%releases-tag%/wasm-binaries.tbz2",
3939
"windows_url": "https://storage.googleapis.com/webassembly/emscripten-releases-builds/win/%releases-tag%/wasm-binaries.zip",
4040
"zipfile_prefix": "%releases-tag%-",
41-
"install_path": "upstream",
41+
"install_path": "prebuilt",
4242
"activated_path": "%installation_dir%/emscripten",
4343
"activated_cfg": "LLVM_ROOT='%installation_dir%/bin';BINARYEN_ROOT='%installation_dir%';EMSCRIPTEN_ROOT='%installation_dir%/emscripten'",
4444
"emscripten_releases_hash": "%releases-tag%"
@@ -51,7 +51,7 @@
5151
"macos_url": "https://storage.googleapis.com/webassembly/emscripten-releases-builds/mac/%releases-tag%/wasm-binaries-arm64.tbz2",
5252
"linux_url": "https://storage.googleapis.com/webassembly/emscripten-releases-builds/linux/%releases-tag%/wasm-binaries-arm64.tbz2",
5353
"zipfile_prefix": "%releases-tag%-",
54-
"install_path": "upstream",
54+
"install_path": "prebuilt",
5555
"activated_path": "%installation_dir%/emscripten",
5656
"activated_cfg": "LLVM_ROOT='%installation_dir%/bin';BINARYEN_ROOT='%installation_dir%';EMSCRIPTEN_ROOT='%installation_dir%/emscripten'",
5757
"emscripten_releases_hash": "%releases-tag%"

0 commit comments

Comments
 (0)