Skip to content

Commit 4fb9636

Browse files
authored
Merge pull request #127 from enBloc-org/#107/pagination-nav-redesign
#107/pagination nav redesign
2 parents e426b05 + ba76516 commit 4fb9636

File tree

3 files changed

+16
-10
lines changed

3 files changed

+16
-10
lines changed

src/components/PaginationNav/PaginationNav.css

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
display: flex;
33
justify-content: space-evenly;
44
align-items: center;
5-
margin-left: 50%;
5+
margin: 0 auto;
66
margin-top: 10px;
7+
margin-bottom: -10px;
8+
width: 150px;
79
}

src/components/PaginationNav/PaginationNav.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,19 @@ export default function PaginationNav({
2222
return (
2323
<div className="pagination-nav">
2424
<button
25-
className="button--secondary"
25+
className="button--secondary text-md"
2626
onClick={navigateToPrevious}
2727
disabled={pageNumber === 1}
2828
>
29-
previous
29+
{"<<<"}
3030
</button>
31-
<p className="bold">{`${pageNumber} of ${pageCount}`}</p>
31+
<p className="bold text-lg">{`${pageNumber} of ${pageCount}`}</p>
3232
<button
33-
className="button--secondary"
33+
className="button--secondary text-md"
3434
onClick={navigateToNext}
3535
disabled={pageNumber === pageCount}
3636
>
37-
next
37+
{">>>"}
3838
</button>
3939
</div>
4040
)

src/components/page-components/FavouritesPage/FavouritesPage.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,13 @@ export default function FavouritesPage() {
4343

4444
if (error) return showBoundary(error)
4545

46-
setFavouritesList(previous =>
47-
previous.filter(favourite => favourite.id !== givenId)
46+
const newFavourites = favouritesList.filter(
47+
favourite => favourite.id !== givenId
4848
)
49+
if (newFavourites.length === 0)
50+
setPageNumber(previous => previous - 1)
51+
52+
setFavouritesList(newFavourites)
4953
}
5054

5155
useEffect(() => {
@@ -95,14 +99,14 @@ export default function FavouritesPage() {
9599
})
96100

97101
if (popupError) return showBoundary(popupError)
98-
if (meta.pagination.pageCount !== 1)
102+
if (meta.pagination.pageCount !== pageCount)
99103
setPageCount(meta.pagination.pageCount)
100104

101105
setFavouritesList(popupData)
102106
}
103107

104108
getFavourites()
105-
}, [setFavouritesList, pageNumber])
109+
}, [setFavouritesList, pageNumber, favouritesList.length % 6 === 0])
106110

107111
return (
108112
<div className="favourites-page page">

0 commit comments

Comments
 (0)