Skip to content

Commit a825a83

Browse files
committed
Fix the error in generating the idle connection list
1 parent e987df2 commit a825a83

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

httpcore/_async/connection_pool.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,13 @@ def _assign_requests_to_connections(self) -> List[AsyncConnectionInterface]:
251251
closing_connections.append(connection)
252252
elif (
253253
connection.is_idle()
254-
and len([connection.is_idle() for connection in self._connections])
254+
and len(
255+
[
256+
connection
257+
for connection in self._connections
258+
if connection.is_idle()
259+
]
260+
)
255261
> self._max_keepalive_connections
256262
):
257263
# log: "closing idle connection"

httpcore/_sync/connection_pool.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,13 @@ def _assign_requests_to_connections(self) -> List[ConnectionInterface]:
251251
closing_connections.append(connection)
252252
elif (
253253
connection.is_idle()
254-
and len([connection.is_idle() for connection in self._connections])
254+
and len(
255+
[
256+
connection
257+
for connection in self._connections
258+
if connection.is_idle()
259+
]
260+
)
255261
> self._max_keepalive_connections
256262
):
257263
# log: "closing idle connection"

0 commit comments

Comments
 (0)