Skip to content

Commit 252068c

Browse files
v1rtlclaude
andcommitted
fix: point Sepolia ensPublicResolver at the V1 resolver
`ensPublicResolver` is a V1 contract key: it sits in the v1 group of `supportedL1Contracts`, mainnet holds the V1 address, and every reader is a V1 action — `dns/importDnsName` and `wallet/v1/{setPrimaryName,createSubname,wrapName}`. Each passes it as the resolver for a V1 registry write, so it must implement the legacy `addr` interface. 3799148 repointed the Sepolia entry at the V2 public resolver, which does not implement it (`supportsInterface(0x3b3b57de)` returns false). `DNSRegistrar.proveAndClaimWithResolver` consequently reverts inside `setAddr`, making onchain DNS import impossible on Sepolia; the other three actions are broken the same way for anyone calling them. Verified against a Sepolia fork: with 0x8FADE66B… the import lands and the V2 UniversalResolver reads the name back through ENSV1Resolver. That address is also what live Sepolia names (ens.eth, nick.eth, test.eth) resolve through today. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 4018fc9 commit 252068c

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

  • packages/ensjs/src/clients

packages/ensjs/src/clients/l1.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,12 @@ export const ensL1Contracts = {
156156
ensNameWrapper: {
157157
address: '0x0635513f179D50A207757E05759CbD106d7dFcE8',
158158
},
159+
// The V1 PublicResolver. Only V1 actions read this key (dns/importDnsName,
160+
// wallet/v1/{setPrimaryName,createSubname,wrapName}), and they pass it as a
161+
// resolver for the V1 registry — so it must implement the legacy `addr`
162+
// interface. The V2 public resolver does not, and belongs under its own key.
159163
ensPublicResolver: {
160-
address: '0x5239A812ec9A62F46dbb5de8f346C8eFe7553A9f',
164+
address: '0x8FADE66B79cC9f707aB26799354482EB93a5B7dD',
161165
},
162166
ensLegacyRegistry: {
163167
address: '0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e',

0 commit comments

Comments
 (0)