-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Open
Labels
bugdepsApproval required for changes to Envoy's external dependenciesApproval required for changes to Envoy's external dependencies
Description
Title: bazel/dependency_imports.bzl Missing Directives
Description:
When building for darwin-arm64, some golang dependencies can't be found. Adding the missing directives seems to work
Repro steps:
- Download bazel 7.7.1 and envoy 1.37.1 releases
- Unpack both on macOS 26.3.1, with access to Xcode 26.3
- Run
python3 tools/github/write_current_source_version.py - Run
bazel --output_base=BASE_DIR --output_user_root=USER_DIR build -c opt envoy.stripped - Build fails with missing dependencies (see inline patch below)
Notes:
This was built in a RAM disk on macOS, and both output directories were remapped there. The build occupied ~22 GiB.
Patch:
--- bazel/dependency_imports.bzl 2026-03-10 21:23:03
+++ bazel/dependency_imports.bzl 2026-03-24 19:18:25
@@ -172,6 +172,11 @@
sum = "h1:EaGW2JJh15aKOejeuJ+wpFSHnbd7GE6Wvp3TsNhb6LY=",
version = "v1.10.0",
build_external = "external",
+ build_directives = [
+ "gazelle:resolve go golang.org/x/text/runes @org_golang_x_text//runes",
+ "gazelle:resolve go golang.org/x/text/transform @org_golang_x_text//transform",
+ "gazelle:resolve go golang.org/x/text/unicode/norm @org_golang_x_text//unicode/norm",
+ ],
)
go_repository(
name = "com_github_lyft_protoc_gen_star_v2",
@@ -179,6 +184,9 @@
sum = "h1:sIXJOMrYnQZJu7OB7ANSF4MYri2fTEGIsRLz6LwI4xE=",
version = "v2.0.4-0.20230330145011-496ad1ac90a4",
build_external = "external",
+ build_directives = [
+ "gazelle:resolve go golang.org/x/tools/imports @org_golang_x_tools//imports",
+ ],
)
go_repository(
name = "com_github_iancoleman_strcase",
Please excuse the report if this is a duplicate.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugdepsApproval required for changes to Envoy's external dependenciesApproval required for changes to Envoy's external dependencies