check redirect respose filter

Signed-off-by: Huabing Zhao <[email protected]>

Author: zhaohuabing

internal/gatewayapi/filters.go

@@ -70,6 +70,7 @@ type HTTPFilterIR struct {
 var HeaderValueRegexp = regexp.MustCompile(`^[!-~]+([\t ]?[!-~]+)*$`)
 
 const requestMirrorDirectResponseConflictMsg = "RequestMirror filter cannot be used when the rule also configures a DirectResponse filter"
+const requestMirrorRedirectConflictMsg = "RequestMirror filter cannot be used when the rule also configures a RequestRedirect filter"
 
 // ProcessHTTPFilters translates gateway api http filters to IRs.
 func (t *Translator) ProcessHTTPFilters(parentRef *RouteParentContext,
@@ -116,9 +117,13 @@ func (t *Translator) ProcessHTTPFilters(parentRef *RouteParentContext,
 		}
 	}
 
+	// Check for conflicts between RequestMirror and DirectResponse or RequestRedirect filters
 	if httpFiltersContext.DirectResponse != nil && len(httpFiltersContext.Mirrors) > 0 {
 		updateRouteStatusForFilter(httpFiltersContext, requestMirrorDirectResponseConflictMsg)
 	}
+	if httpFiltersContext.RedirectResponse != nil && len(httpFiltersContext.Mirrors) > 0 {
+		updateRouteStatusForFilter(httpFiltersContext, requestMirrorRedirectConflictMsg)
+	}
 
 	return httpFiltersContext, err
 }

internal/gatewayapi/testdata/httproute-with-mirror-filter-direct-response.in.yaml renamed to internal/gatewayapi/testdata/httproute-with-conflicting-filters.in.yaml

@@ -47,6 +47,34 @@ httpRoutes:
                 group: gateway.envoyproxy.io
                 kind: HTTPRouteFilter
                 name: mirror-direct-response
+  - apiVersion: gateway.networking.k8s.io/v1
+    kind: HTTPRoute
+    metadata:
+      namespace: default
+      name: mirror-request-redirect
+    spec:
+      hostnames:
+        - gateway.envoyproxy.io
+      parentRefs:
+        - namespace: envoy-gateway
+          name: gateway-1
+          sectionName: http
+      rules:
+        - matches:
+            - path:
+                type: PathPrefix
+                value: /mirror-redirect
+          filters:
+            - type: RequestMirror
+              requestMirror:
+                backendRef:
+                  kind: Service
+                  name: service-1
+                  port: 8080
+            - type: RequestRedirect
+              requestRedirect:
+                scheme: https
+                statusCode: 302
 httpFilters:
   - apiVersion: gateway.envoyproxy.io/v1alpha1
     kind: HTTPRouteFilter

internal/gatewayapi/testdata/httproute-with-mirror-filter-direct-response.out.yaml renamed to internal/gatewayapi/testdata/httproute-with-conflicting-filters.out.yaml

@@ -16,7 +16,7 @@ gateways:
       protocol: HTTP
   status:
     listeners:
-    - attachedRoutes: 1
+    - attachedRoutes: 2
       conditions:
       - lastTransitionTime: null
         message: Sending translated listener configuration to the data plane
@@ -91,6 +91,53 @@ httpRoutes:
         name: gateway-1
         namespace: envoy-gateway
         sectionName: http
+- apiVersion: gateway.networking.k8s.io/v1
+  kind: HTTPRoute
+  metadata:
+    name: mirror-request-redirect
+    namespace: default
+  spec:
+    hostnames:
+    - gateway.envoyproxy.io
+    parentRefs:
+    - name: gateway-1
+      namespace: envoy-gateway
+      sectionName: http
+    rules:
+    - filters:
+      - requestMirror:
+          backendRef:
+            kind: Service
+            name: service-1
+            port: 8080
+        type: RequestMirror
+      - requestRedirect:
+          scheme: https
+          statusCode: 302
+        type: RequestRedirect
+      matches:
+      - path:
+          type: PathPrefix
+          value: /mirror-redirect
+  status:
+    parents:
+    - conditions:
+      - lastTransitionTime: null
+        message: RequestMirror filter cannot be used when the rule also configures
+          a RequestRedirect filter
+        reason: UnsupportedValue
+        status: "False"
+        type: Accepted
+      - lastTransitionTime: null
+        message: Resolved all the Object references for the Route
+        reason: ResolvedRefs
+        status: "True"
+        type: ResolvedRefs
+      controllerName: gateway.envoyproxy.io/gatewayclass-controller
+      parentRef:
+        name: gateway-1
+        namespace: envoy-gateway
+        sectionName: http
 infraIR:
   envoy-gateway/gateway-1:
     proxy: