Possible unexpanded macro

[damib]

autosave/asApp/src/dbrestore.c

Line 953 in 3283ed1

/* No, we didn't. One more read will certainly accumulate a value string of length BUF_SIZE */

The code is going to concatenate two buffers after macro expansion, so a macro falling between the two buffers will not be expanded.

[ralphlange]

Isn't this about restoring an autosave file, i.e. a file that has been written using actual data from the database before? How is this related to macro expansion?

[damib]

Hi Ralph, you are right, nevertheless the code is currently expanding macro on those buffers (look at line 958), I don't know if this was on purpose or not, may be the macro substitution on the value string.

[timmmooney]

Yeah, this is a bug, alright. It does intend to expand a macro that could begin on one buffer and end in the next buffer. It should expand after concatenating. (It's unusual for autosave to restore a file that contains unexpanded macros. This happens only if the file was edited by hand, which I do for some files used by configMenu to hold softGlue circuits. It's handy if people can load an example circuit without having to edit the .cfg file so it has their IOC prefix.)

[mark0n]

Hmm, I'm wondering if it's really necessary to do macro expansion in autosave. Shouldn't it be the user's responsibility to expand macros if he chooses to put them in manually (e.g. using msi)?