Skip to content

Commit 5b70055

Browse files
seemkblumamir
andauthored
chore(mysql): remove mysql from dependencies (open-telemetry#1445)
* chore(mysql): remove mysql from dependencies * fix: import type --------- Co-authored-by: Amir Blum <[email protected]>
1 parent 7d070db commit 5b70055

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

plugins/node/opentelemetry-instrumentation-mysql/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
"@types/sinon": "10.0.13",
5757
"gts": "3.1.0",
5858
"mocha": "7.2.0",
59+
"mysql": "2.18.1",
5960
"nyc": "15.1.0",
6061
"rimraf": "4.2.0",
6162
"sinon": "15.0.1",
@@ -65,7 +66,6 @@
6566
"dependencies": {
6667
"@opentelemetry/instrumentation": "^0.35.1",
6768
"@opentelemetry/semantic-conventions": "^1.0.0",
68-
"mysql": "2.18.1",
6969
"@types/mysql": "2.15.19"
7070
},
7171
"homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-mysql#readme"

plugins/node/opentelemetry-instrumentation-mysql/src/utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import type {
2222
Query,
2323
QueryOptions,
2424
} from 'mysql';
25-
import * as mysqlTypes from 'mysql';
25+
import type * as mysqlTypes from 'mysql';
2626

2727
/**
2828
* Get an SpanAttributes map from a mysql connection config object

0 commit comments

Comments
 (0)