Skip to content

Commit 9f82d10

Browse files
authored
chore: fix typos and remove unwanted devDependency (open-telemetry#396)
1 parent fab4762 commit 9f82d10

File tree

9 files changed

+12
-12
lines changed

9 files changed

+12
-12
lines changed

packages/opentelemetry-core/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
"keywords": [
2424
"opentelemetry",
2525
"nodejs",
26+
"browser",
2627
"tracing",
2728
"profiling",
2829
"metrics",

packages/opentelemetry-plugin-grpc/test/grpc.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ function startServer(grpc: GrpcModule, proto: any) {
189189
}
190190

191191
server.addService(proto.GrpcTester.service, {
192-
// An error is emited every time
192+
// An error is emitted every time
193193
// request.num <= MAX_ERROR_STATUS = (status.UNAUTHENTICATED)
194194
// in those cases, erro.code = request.num
195195

packages/opentelemetry-plugin-http/src/utils.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,8 @@ export const satisfiesPattern = <T>(
126126
* It will not re-throw exceptions from `list` provided by the client
127127
* @param constant e.g URL of request
128128
* @param [list] List of ignore patterns
129-
* @param [onException] callback for doing something when an exception has occured
129+
* @param [onException] callback for doing something when an exception has
130+
* occurred
130131
*/
131132
export const isIgnored = (
132133
constant: string,

packages/opentelemetry-scope-async-hooks/README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,18 @@ This package provides [async-hooks][async-hooks-doc] based scope manager which i
88

99
## What is a ScopeManager ?
1010

11-
The definition and why they exist is available on [the readme of the socpe-base package][def-scope-manager].
11+
The definition and why they exist is available on [the readme of the scope-base package][def-scope-manager].
1212

1313
### Implementation in NodeJS
1414

15-
NodeJS has a specific API to track async scope: [async-hooks][async-hooks-doc], it allows to track creation of new async operation and their respective parent.
15+
NodeJS has a specific API to track async scope: [async-hooks][async-hooks-doc], it allows to track creation of new async operation and their respective parent.
1616
This package only handle storing a specific object for a given async hooks context.
1717

1818
### Limitations
1919

2020
Even if the API is native to NodeJS, it doesn't cover all possible cases of scope propagation but there is a big effort from the NodeJS team to fix those. That's why we generally advise to be on the latest LTS to benefit from performance and bug fixes.
2121

22-
There are known modules that break scope propagation ([somes of them are listed there][pkgs-that-break-ah]), so it's possible that the scope manager doesn't work with them.
22+
There are known modules that break scope propagation ([some of them are listed there][pkgs-that-break-ah]), so it's possible that the scope manager doesn't work with them.
2323

2424
### Prior arts
2525

@@ -52,4 +52,4 @@ Apache 2.0 - See [LICENSE][license-url] for more information.
5252
[dd-js-tracer-scope]: https://github.com/DataDog/dd-trace-js/tree/master/packages/dd-trace/src/scope
5353
[opentracing-scope]: https://github.com/opentracing/opentracing-javascript/pull/113
5454
[diag-team-scope-discussion]: https://github.com/nodejs/diagnostics/issues/300
55-
[pkgs-that-break-ah]: https://github.com/nodejs/diagnostics/blob/master/tracing/AsyncHooks/problematic-modules.md
55+
[pkgs-that-break-ah]: https://github.com/nodejs/diagnostics/blob/master/tracing/AsyncHooks/problematic-modules.md

packages/opentelemetry-scope-base/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"keywords": [
1818
"opentelemetry",
1919
"nodejs",
20+
"browser",
2021
"tracing",
2122
"profiling",
2223
"metrics",

packages/opentelemetry-shim-opentracing/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
OpenTracing shim allows existing OpenTracing instrumentation to report to OpenTelemetry
88

9-
Note: Baggage is currently not progagated, see [issues/329](https://github.com/open-telemetry/opentelemetry-js/issues/329).
9+
Note: Baggage is currently not propagated, see [issues/329](https://github.com/open-telemetry/opentelemetry-js/issues/329).
1010

1111
## Installation
1212

packages/opentelemetry-shim-opentracing/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
"@types/mocha": "^5.2.7",
3939
"@types/node": "^12.6.9",
4040
"@opentelemetry/tracer-basic": "^0.1.0",
41-
"@opentelemetry/scope-base": "^0.1.0",
4241
"codecov": "^3.5.0",
4342
"gts": "^1.1.0",
4443
"mocha": "^6.2.0",

packages/opentelemetry-shim-opentracing/test/Shim.test.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,12 @@
1717
import * as assert from 'assert';
1818
import * as opentracing from 'opentracing';
1919
import { BasicTracer, Span } from '@opentelemetry/tracer-basic';
20-
import { NoopScopeManager } from '@opentelemetry/scope-base';
2120
import { TracerShim, SpanShim, SpanContextShim } from '../src/shim';
2221
import { INVALID_SPAN_CONTEXT, timeInputToHrTime } from '@opentelemetry/core';
2322
import { performance } from 'perf_hooks';
2423

2524
describe('OpenTracing Shim', () => {
26-
const tracer = new BasicTracer({
27-
scopeManager: new NoopScopeManager(),
28-
});
25+
const tracer = new BasicTracer();
2926
const shimTracer: opentracing.Tracer = new TracerShim(tracer);
3027
opentracing.initGlobalTracer(shimTracer);
3128

packages/opentelemetry-types/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"keywords": [
1818
"opentelemetry",
1919
"nodejs",
20+
"browser",
2021
"tracing",
2122
"profiling",
2223
"metrics",

0 commit comments

Comments
 (0)