adding tests

Author: galbash

instrumentation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/utils.py

@@ -199,6 +199,7 @@ def _enrich_span(
         )
 
 
+# pylint:disable=abstract-method
 class ReadyMessagesDequeProxy(ObjectProxy):
     def __init__(
         self,
@@ -225,7 +226,7 @@ def popleft(self, *args, **kwargs):
 
         try:
             # If a new message was received, create a span and set as active context
-            if type(evt) is _ConsumerDeliveryEvt:
+            if isinstance(evt, _ConsumerDeliveryEvt):
                 method = evt.method
                 properties = evt.properties
                 if not properties:

instrumentation/opentelemetry-instrumentation-pika/tests/test_utils.py

@@ -455,6 +455,7 @@ def test_decorate_basic_publish_when_span_is_not_recording(
         )
         self.assertEqual(retval, callback.return_value)
 
+    # pylint: disable=too-many-statements
     @mock.patch("opentelemetry.instrumentation.pika.utils._get_span")
     @mock.patch("opentelemetry.propagate.extract")
     @mock.patch("opentelemetry.context.detach")
@@ -471,18 +472,16 @@ def test_decorate_deque_proxy(
         returned_span = mock.MagicMock()
         get_span.return_value = returned_span
         consume_hook = mock.MagicMock()
-        mock_task_name = "mock_task_name"
         tracer = mock.MagicMock()
         generator_info = mock.MagicMock(
             spec=_QueueConsumerGeneratorInfo,
             pending_events=mock.MagicMock(spec=collections.deque),
-            consumer_tag=mock_task_name,
+            consumer_tag="mock_task_name",
         )
         method = mock.MagicMock(spec=Basic.Deliver)
         method.exchange = "test_exchange"
         properties = mock.MagicMock()
-        mock_body = b"mock_body"
-        evt = _ConsumerDeliveryEvt(method, properties, mock_body)
+        evt = _ConsumerDeliveryEvt(method, properties, b"mock_body")
         generator_info.pending_events.popleft.return_value = evt
         proxy = utils.ReadyMessagesDequeProxy(
             generator_info.pending_events, generator_info, tracer, consume_hook
@@ -504,7 +503,7 @@ def test_decorate_deque_proxy(
             properties,
             destination=method.exchange,
             span_kind=SpanKind.CONSUMER,
-            task_name=mock_task_name,
+            task_name=generator_info.consumer_tag,
             operation=MessagingOperationValues.RECEIVE,
         )
         consume_hook.assert_called_once()
@@ -535,7 +534,7 @@ def test_decorate_deque_proxy(
             properties,
             destination=method.exchange,
             span_kind=SpanKind.CONSUMER,
-            task_name=mock_task_name,
+            task_name=generator_info.consumer_tag,
             operation=MessagingOperationValues.RECEIVE,
         )
         consume_hook.assert_called_once()