Skip to content

Commit 7737f53

Browse files
committed
2 parents 7fb531d + 7408bb7 commit 7737f53

File tree

118 files changed

+466
-2109
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

118 files changed

+466
-2109
lines changed

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Publish
22

33
on:
44
release:
5-
types: [created]
5+
types: [published]
66

77
jobs:
88
publish:

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- 'release/*'
77
pull_request:
88
env:
9-
CORE_REPO_SHA: c4cdffd0c8bd47b2e5c4f4a823722ca514f10db3
9+
CORE_REPO_SHA: 67bbad45917baa354a3a6d0d4361da48ff13fd31
1010

1111
jobs:
1212
build:

CHANGELOG.md

Lines changed: 28 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8-
## [Unreleased](https://github.com/open-telemetry/opentelemetry-python/compare/v1.3.0-0.22b0...HEAD)
9-
- `opentelemetry-sdk-extension-aws` Update AWS entry points to match spec
10-
([#566](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/566))
11-
- Include Flask 2.0 as compatible with existing flask instrumentation
12-
([#545](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/545))
13-
- `openelemetry-sdk-extension-aws` Take a dependency on `opentelemetry-sdk`
14-
([#558](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/558))
8+
## [Unreleased](https://github.com/open-telemetry/opentelemetry-python/compare/v1.4.0-0.23b0...HEAD)
9+
10+
## [1.4.0-0.23b0](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.4.0-0.23b0) - 2021-07-19
11+
12+
13+
14+
### Removed
15+
- Move `opentelemetry-instrumentation` to the core repo.
16+
([#595](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/595))
1517

1618
### Changed
1719
- `opentelemetry-instrumentation-tornado` properly instrument work done in tornado on_finish method.
@@ -34,8 +36,27 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3436
- Updating dependency for opentelemetry api/sdk packages to support major version instead
3537
of pinning to specific versions.
3638
([#567](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/567))
39+
- `opentelemetry-instrumentation-grpc` Respect the suppress instrumentation in gRPC client instrumentor
40+
([#559](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/559))
3741
- `opentelemetry-instrumentation-grpc` Fixed asynchonous unary call traces
3842
([#536](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/536))
43+
- `opentelemetry-sdk-extension-aws` Update AWS entry points to match spec
44+
([#566](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/566))
45+
- Include Flask 2.0 as compatible with existing flask instrumentation
46+
([#545](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/545))
47+
- `openelemetry-sdk-extension-aws` Take a dependency on `opentelemetry-sdk`
48+
([#558](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/558))
49+
- Change `opentelemetry-instrumentation-httpx` to replace `client` classes with instrumented versions.
50+
([#577](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/577))
51+
- `opentelemetry-instrumentation-requests` Fix potential `AttributeError` when `requests`
52+
is used with a custom transport adapter.
53+
([#562](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/562))
54+
- `opentelemetry-instrumentation-django` Fix AttributeError: ResolverMatch object has no attribute route
55+
([#581](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/581))
56+
- `opentelemetry-instrumentation-botocore` Suppress botocore downstream instrumentation like urllib3
57+
([#563](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/563))
58+
- `opentelemetry-exporter-datadog` Datadog exporter should not use `unknown_service` as fallback resource service name.
59+
([#570](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/570))
3960

4061
### Added
4162
- `opentelemetry-instrumentation-httpx` Add `httpx` instrumentation

_template/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
__version__ = "0.23.dev0"
15+
__version__ = "0.23b0"

docs-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ sphinx-autodoc-typehints
66
# doesn't work for pkg_resources.
77
-e "git+https://github.com/open-telemetry/opentelemetry-python.git#egg=opentelemetry-api&subdirectory=opentelemetry-api"
88
-e "git+https://github.com/open-telemetry/opentelemetry-python.git#egg=opentelemetry-semantic-conventions&subdirectory=opentelemetry-semantic-conventions"
9-
-e "git+https://github.com/open-telemetry/opentelemetry-python-contrib.git#egg=opentelemetry-instrumentation&subdirectory=opentelemetry-instrumentation"
9+
-e "git+https://github.com/open-telemetry/opentelemetry-python.git#egg=opentelemetry-instrumentation&subdirectory=opentelemetry-instrumentation"
1010
-e "git+https://github.com/open-telemetry/opentelemetry-python.git#egg=opentelemetry-sdk&subdirectory=opentelemetry-sdk"
1111
-e "git+https://github.com/open-telemetry/opentelemetry-python-contrib.git#egg=opentelemetry-util-http&subdirectory=util/opentelemetry-util-http"
1212

docs/conf.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@
2525
settings.configure()
2626

2727
source_dirs = [
28-
os.path.abspath("../opentelemetry-instrumentation/src/"),
28+
os.path.abspath(
29+
"../opentelemetry-python-core/opentelemetry-instrumentation/src/"
30+
),
2931
]
3032

3133
exp = "../exporter"

eachdist.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ sortfirst=
1717
ext/*
1818

1919
[stable]
20-
version=1.4.0.dev0
20+
version=1.4.0
2121

2222
packages=
2323
opentelemetry-sdk
@@ -35,7 +35,7 @@ packages=
3535
opentelemetry-api
3636

3737
[prerelease]
38-
version=0.23.dev0
38+
version=0.23b0
3939

4040
packages=
4141
all

exporter/opentelemetry-exporter-datadog/setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ install_requires =
4141
ddtrace>=0.34.0,<0.47.0
4242
opentelemetry-api ~= 1.3
4343
opentelemetry-sdk ~= 1.3
44-
opentelemetry-semantic-conventions == 0.23.dev0
44+
opentelemetry-semantic-conventions == 0.23b0
4545

4646
[options.packages.find]
4747
where = src

exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog/exporter.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -135,12 +135,12 @@ def _translate_to_datadog(self, spans):
135135
[
136136
resource_tags,
137137
resource_service_name,
138-
] = _extract_tags_from_resource(span.resource)
138+
] = _extract_tags_from_resource(span.resource, self.service)
139139

140140
datadog_span = DatadogSpan(
141141
tracer,
142142
_get_span_name(span),
143-
service=resource_service_name or self.service,
143+
service=resource_service_name,
144144
resource=_get_resource(span),
145145
span_type=_get_span_type(span),
146146
trace_id=trace_id,
@@ -312,19 +312,23 @@ def _parse_tags_str(tags_str):
312312
return parsed_tags
313313

314314

315-
def _extract_tags_from_resource(resource):
315+
def _extract_tags_from_resource(resource, fallback_service_name):
316316
"""Parse tags from resource.attributes, except service.name which
317317
has special significance within datadog"""
318318
tags = {}
319-
service_name = None
320319
if not (resource and getattr(resource, "attributes", None)):
321-
return [tags, service_name]
320+
return [tags, fallback_service_name]
322321

322+
service_name = None
323323
for attribute_key, attribute_value in resource.attributes.items():
324324
if attribute_key == SERVICE_NAME_TAG:
325325
service_name = attribute_value
326326
else:
327327
tags[attribute_key] = attribute_value
328+
329+
if service_name is None or service_name == "unknown_service":
330+
service_name = fallback_service_name
331+
328332
return [tags, service_name]
329333

330334

exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
__version__ = "0.23.dev0"
15+
__version__ = "0.23b0"

0 commit comments

Comments
 (0)