aspect clang-tidy.yaml is being produced but not printed to terminal

[nickdesaulniers]

I swear I had this working where following the readme, I could simply build with the addition of --config=clang-tidy and the errors found would be printed to the terminal. But today I'm only seeing:

$ bazel build //some:path --config=clang-tidy
...
Aspect @@bazel_clang_tidy+//clang_tidy:clang_tidy.bzl%clang_tidy_aspect of //some:path up-to-date:
  bazel-bin/some/bazel_clang_tidy_arch/path.cpp.some.clang-tidy.yaml
...

And path.cpp.some.clang-tidy.yaml looks like machine parseable list of diagnostics from clang-tidy. How come they didn't print to my terminal? I tried bisecting back to when I first introduced bazel_clang_tidy to our codebase, but I still don't see output to terminal. I swear I used to. How do I go about debugging what might have changed in my environment?

[nickdesaulniers]

Another clue; it seems this behavior depends on the target or where in my tree I'm trying to run.
Example:

$ bazel build //some:path --config=clang-tidy
...
Aspect @@bazel_clang_tidy+//clang_tidy:clang_tidy.bzl%clang_tidy_aspect of //some:path up-to-date:
  bazel-bin/some/bazel_clang_tidy_arch/path.cpp.some.clang-tidy.yaml
...
$ bazel build //other:path --config=clang-tidy
<warnings as expected>

[nickdesaulniers]

Perhaps I'm misunderstanding the workflow, if I have a clang-diagnostic-error (from indirect header includes), then I see the error and other warnings as expected. Without any errors (from clang-diagnostic-error), I don't see any warnings...what?!

My code compiles fine, I don't understand why bazel_clang_tidy seems to be testing my headers standalone.

[erenon]

Please share your .clang-tidy, if possible. Do you have WarningsAsErrors set? (see example: https://github.com/erenon/bazel_clang_tidy/blob/master/.clang-tidy )

If clang-tidy returns 0 after run, bazel considers the check successful, and swallows the output (I suppose).

[pmaciag]

I faced the very same error. File with warnings was created and was non-empty. At the same time no issue was printed into the terminal.

After a while I realize, that issue was in my .clang-tidy file. The WarningsAsErrors parameter is not a boolean type - you need to provide a list of checks from the list of Checks when clang-tidy should issue an error (not only warning ;) ).

Created file had only warnings, there weren't treated as errors. Everything was "correct". I would like to see an option to bazel_clang_tidy to "treat warnings as errors". So I don't have to copy everything ;)

Hope this helps.

[erenon]

What's wrong with WarnignsAsErrors: "*"?

[pmaciag]

What's wrong with WarnignsAsErrors: "*"?

absolutely nothing. I didn't knew about it. thx @erenon - works like a charm!