cp Integrity check: compare state progress and block progress (#18002)

issue: #17911

Author: sudeepdino008

eth/integrity/commitment_progress_check.go

@@ -0,0 +1,32 @@
+package integrity
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/erigontech/erigon/db/kv"
+	"github.com/erigontech/erigon/turbo/services"
+)
+
+func CheckStateProgress(ctx context.Context, db kv.TemporalRoDB, blockReader services.FullBlockReader, failFast bool) (err error) {
+	// state files should not be ahead of blocks files
+	tx, err := db.BeginTemporalRo(ctx)
+	if err != nil {
+		return err
+	}
+	defer tx.Rollback()
+
+	stateFileProgress := tx.Debug().DomainFiles(kv.CommitmentDomain).EndRootNum()
+
+	txnumReader := blockReader.TxnumReader(ctx)
+	blockFileProgress, err := txnumReader.Max(tx, blockReader.FrozenBlocks())
+	if err != nil {
+		return err
+	}
+
+	if stateFileProgress > blockFileProgress {
+		return fmt.Errorf("state files progress (%d) is ahead of blocks files progress (%d)", stateFileProgress, blockFileProgress)
+	}
+
+	return nil
+}

eth/integrity/integrity_action_type.go

@@ -29,12 +29,13 @@ const (
 	BorEvents          Check = "BorEvents"
 	BorSpans           Check = "BorSpans"
 	BorCheckpoints     Check = "BorCheckpoints"
+	StateProgress      Check = "StateProgress" // state files is not ahead of blocks files
 	Publishable        Check = "Publishable"
 )
 
 var AllChecks = []Check{
 	Blocks, HeaderNoGaps, BlocksTxnID, InvertedIndex, HistoryNoSystemTxs, ReceiptsNoDups, BorEvents,
-	BorSpans, BorCheckpoints, RCacheNoDups, Publishable,
+	BorSpans, BorCheckpoints, RCacheNoDups, StateProgress, Publishable,
 }
 
 var NonDefaultChecks = []Check{}

turbo/app/snapshots_cmd.go

@@ -897,6 +897,10 @@ func doIntegrity(cliCtx *cli.Context) error {
 			if err := integrity.CheckRCacheNoDups(ctx, db, blockReader, failFast); err != nil {
 				return err
 			}
+		case integrity.StateProgress:
+			if err := integrity.CheckStateProgress(ctx, db, blockReader, failFast); err != nil {
+				return err
+			}
 		case integrity.Publishable:
 			if err := doPublishable(cliCtx); err != nil {
 				return err