Add support for MetaProperty (import.meta and new.target)#129
Closed
JordanMartinez wants to merge 1 commit intoquintenkasteel:new-astfrom
JordanMartinez:supportMetaProperty
Closed
Add support for MetaProperty (import.meta and new.target)#129JordanMartinez wants to merge 1 commit intoquintenkasteel:new-astfrom JordanMartinez:supportMetaProperty
import.meta and new.target)#129JordanMartinez wants to merge 1 commit intoquintenkasteel:new-astfrom
JordanMartinez:supportMetaProperty
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Fixes #127
ImportMeta is one of the paths for MetaProperty, which is one of the paths for MemberExpression.
Since
metaandtargetare not keywords, I'm not sure how to properly account for them in the Lexer without making every instance ofmetaortargetbe parsed asMetaTokenorTargetToken. I thought I could follow what's currently being done forGetTokenandSetToken, but I'm guessing that's incorrect.